8000 Remove return void PHPDoc in test by fancyweb · Pull Request #44440 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Remove return void PHPDoc in test #44440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2021
Merged

Remove return void PHPDoc in test #44440

merged 1 commit into from
Dec 3, 2021

Conversation

fancyweb
Copy link
Contributor
@fancyweb fancyweb commented Dec 3, 2021
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

AFAIK we don't add them in tests and that's why the CI is not green on 6.0 and 6.1 (see https://github.com/symfony/symfony/runs/4405273301?check_suite_focus=true for example).

@carsonbot carsonbot added this to the 4.4 milestone Dec 3, 2021
@fancyweb fancyweb merged commit c33a1fa into symfony:4.4 Dec 3, 2021
@fancyweb fancyweb deleted the minor/return-void branch December 3, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@fancyweb @nicolas-grekas @xabbuh @carsonbot
0