8000 Missing translations for Belarusian (be) #41032 by zaneevat · Pull Request #44404 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Missing translations for Belarusian (be) #41032 #44404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2021
Merged

Missing translations for Belarusian (be) #41032 #44404

merged 1 commit into from
Dec 11, 2021

Conversation

zaneevat
Copy link
Contributor
@zaneevat zaneevat commented Dec 1, 2021
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #41032
License MIT
Doc PR N/A

@carsonbot carsonbot added this to the 4.4 milestone Dec 1, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@fabpot
Copy link
Member
fabpot commented Dec 11, 2021

Thank you @zaneevat.

@fabpot fabpot merged commit 0690a6c into symfony:4.4 Dec 11, 2021
@zaneevat zaneevat deleted the ticket_41032 branch December 15, 2021 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@zaneevat @carsonbot @fabpot
0