Fix redundant type casts #44330
Merged
Fix redundant type casts #44330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Nov 29, 2021
fancyweb
commented
Nov 29, 2021
| @@ -75,7 +75,7 @@ public static function createChoiceLabel(object $choice): string | |||
| */ | |||
| public static function createChoiceName(object $choice, $key, string $value): string | |||
| { | |||
| return str_replace('-', '_', (string) $value); | |||
| return str_replace('-', '_', $value); | |||
There was a problem hiding this comment.
string $value in args
@@ -107,7 +107,7 @@ private function __construct(array $thresholds = [], $regex = '', $verboseOutput
if (!isset($this->verboseOutput[$group])) {
throw new \InvalidArgumentException(sprintf('Unsupported verbosity group "%s", expected one of "%s".', $group, implode('", "', array_keys($this->verboseOutput))));
}
$this->verboseOutput[$group] = (bool) $status;
$this->verboseOutput[$group] = $status;
There was a problem hiding this comment.
@param bool[] $verboseOutput in the doc + the constructor is private and only called with a $verboseOutput in fromUrlEncodedString() and inWeakMode() and we always set valid booleans values.
| @@ -107,7 +107,7 @@ private function __construct(array $thresholds = [], $regex = '', $verboseOutput | |||
| if (!isset($this->verboseOutput[$group])) { | |||
| throw new \InvalidArgumentException(sprintf('Unsupported verbosity group "%s", expected one of "%s".', $group, implode('", "', array_keys($this->verboseOutput)))); | |||
| } | |||
| $this->verboseOutput[$group] = (bool) $status; | |||
| $this->verboseOutput[$group] = $status; | |||
There was a problem hiding this comment.
@param bool[] $verboseOutput in the doc + the constructor is private and only called with a $verboseOutput in fromUrlEncodedString() and inWeakMode() and we always set valid booleans values.
| @@ -59,7 +59,7 @@ protected function setUp(): void | |||
|
|
|||
| protected function renderForm(FormView $view, array $vars = []): string | |||
| { | |||
| return (string) $this->renderer->renderBlock($view, 'form', $vars); | |||
| return $this->renderer->renderBlock($view, 'form', $vars); | |||
There was a problem hiding this comment.
FormRendererInterface::renderBlock() returns a string
| @@ -105,7 +105,7 @@ public function setHidden(bool $hidden) | |||
| throw new LogicException('A hidden question cannot use the autocompleter.'); | |||
| } | |||
|
|
|||
| $this->hidden = (bool) $hidden; | |||
| $this->hidden = $hidden; | |||
There was a problem hiding this comment.
bool $hidden in args
| @@ -127,7 +127,7 @@ public function isHiddenFallback() | |||
| */ | |||
| public function setHiddenFallback(bool $fallback) | |||
| { | |||
| $this->hiddenFallback = (bool) $fallback; | |||
| $this->hiddenFallback = $fallback; | |||
There was a problem hiding this comment.
bool $fallback in args
| @@ -72,7 +72,7 @@ public function escape(string $subject, string $ignore = '', int $flags = 0) | |||
| $value = ldap_escape($subject, $ignore, $flags); | |||
|
|
|||
| // Per RFC 4514, leading/trailing spaces should be encoded in DNs, as well as carriage returns. | |||
| if ((int) $flags & \LDAP_ESCAPE_DN) { | |||
| if ($flags & \LDAP_ESCAPE_DN) { | |||
There was a problem hiding this comment.
int $flags = 0 in args
| @@ -455,7 +455,7 @@ protected function computeFallbackLocales(string $locale) | |||
| */ | |||
| protected function assertValidLocale(string $locale) | |||
| { | |||
| if (!preg_match('/^[a-z0-9@_\\.\\-]*$/i', (string) $locale)) { | |||
| if (!preg_match('/^[a-z0-9@_\\.\\-]*$/i', $locale)) { | |||
There was a problem hiding this comment.
string $locale in args
| @@ -67,7 +67,7 @@ protected function addNamespaceAlias(string $alias, string $namespace) | |||
| protected function newConstraint(string $name, $options = null) | |||
| { | |||
| if (str_contains($name, '\\') && class_exists($name)) { | |||
| $className = (string) $name; | |||
| $className = $name; | |||
There was a problem hiding this comment.
string $name in args
| @@ -207,7 +207,7 @@ public function __toString() | |||
| public function withMaxDepth(int $maxDepth) | |||
| { | |||
| $data = clone $this; | |||
| $data->maxDepth = (int) $maxDepth; | |||
| $data->maxDepth = $maxDepth; | |||
There was a problem hiding this comment.
int $maxDepth in args
| @@ -220,7 +220,7 @@ public function withMaxDepth(int $maxDepth) | |||
| public function withMaxItemsPerDepth(int $maxItemsPerDepth) | |||
| { | |||
| $data = clone $this; | |||
| $data->maxItemsPerDepth = (int) $maxItemsPerDepth; | |||
| $data->maxItemsPerDepth = $maxItemsPerDepth; | |||
There was a problem hiding this comment.
int $maxItemsPerDepth in args
|
Thank you @fancyweb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #44274 on 5.3