Fix redundant type casts #44330
Fix redundant type casts #44330
Conversation
| public static function createChoiceName(object $choice, $key, string $value): string | ||
| { | ||
| return str_replace('-', '_', (string) $value); | ||
| return str_replace('-', '_', $value); |
There was a problem hiding this comment.
string $value in args
| throw new \InvalidArgumentException(sprintf('Unsupported verbosity group "%s", expected one of "%s".', $group, implode('", "', array_keys($this->verboseOutput)))); | ||
| } | ||
| $this->verboseOutput[$group] = (bool) $status; | ||
| $this->verboseOutput[$group] = $status; |
There was a problem hiding this comment.
@param bool[] $verboseOutput in the doc + the constructor is private and only called with a $verboseOutput in fromUrlEncodedString() and inWeakMode() and we always set valid booleans values.
| protected function renderForm(FormView $view, array $vars = []): string | ||
| { | ||
| return (string) $this->renderer->renderBlock($view, 'form', $vars); | ||
| return $this->renderer->renderBlock($view, 'form', $vars); |
There was a problem hiding this comment.
FormRendererInterface::renderBlock() returns a string
| } | ||
|
|
||
| $this->hidden = (bool) $hidden; | ||
| $this->hidden = $hidden; |
There was a problem hiding this comment.
bool $hidden in args
| public function setHiddenFallback(bool $fallback) | ||
| { | ||
| $this->hiddenFallback = (bool) $fallback; | ||
| $this->hiddenFallback = $fallback; |
There was a problem hiding this comment.
bool $fallback in args
|
|
||
| // Per RFC 4514, leading/trailing spaces should be encoded in DNs, as well as carriage returns. | ||
| if ((int) $flags & \LDAP_ESCAPE_DN) { | ||
| if ($flags & \LDAP_ESCAPE_DN) { |
There was a problem hiding this comment.
int $flags = 0 in args
| protected function assertValidLocale(string $locale) | ||
| { | ||
| if (!preg_match('/^[a-z0-9@_\\.\\-]*$/i', (string) $locale)) { | ||
| if (!preg_match('/^[a-z0-9@_\\.\\-]*$/i', $locale)) { |
There was a problem hiding this comment.
string $locale in args
| { | ||
| if (str_contains($name, '\\') && class_exists($name)) { | ||
| $className = (string) $name; | ||
| $className = $name; |
There was a problem hiding this comment.
string $name in args
| { | ||
| $data = clone $this; | ||
| $data->maxDepth = (int) $maxDepth; | ||
| $data->maxDepth = $maxDepth; |
There was a problem hiding this comment.
int $maxDepth in args
| { | ||
| $data = clone $this; | ||
| $data->maxItemsPerDepth = (int) $maxItemsPerDepth; | ||
| $data->maxItemsPerDepth = $maxItemsPerDepth; |
There was a problem hiding this comment.
int $maxItemsPerDepth in args
|
Thank you @fancyweb. |
Continuation of #44274 on 5.3