8000 [Framework] Add completion to `debug:event-dispatcher` by GromNaN · Pull Request #44321 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Framework] Add completion to debug:event-dispatcher #44321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2021
Merged

[Framework] Add completion to debug:event-dispatcher #44321

merged 1 commit into from
Nov 29, 2021

Conversation

GromNaN
Copy link
Member
@GromNaN GromNaN commented Nov 28, 2021 •
edited
Loading
Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #43859 #43594
License MIT
Doc PR -

Rework PR from @stephenkhoo

@carsonbot carsonbot added this to the 5.4 milestone Nov 28, 2021
@GromNaN GromNaN force-pushed the pull-43859 branch 3 times, most recently from 5b66228 to f962525 Compare November 28, 2021 23:36
@GromNaN GromNaN requested a review from wouterj November 28, 2021 23:44
@GromNaN GromNaN merged commit 0ac7aa2 into symfony:5.4 Nov 29, 2021
@GromNaN
Copy link
Member Author
GromNaN commented Nov 29, 2021

Thank you @stephenkhoo for doing the hardest part of this.

@GromNaN GromNaN deleted the pull-43859 branch November 29, 2021 08:27
GromNaN
GromNaN commented Nov 29, 2021
View reviewed changes
src/Symfony/Bundle/FrameworkBundle/Tests/Command/EventDispatcherDebugCommandTest.php
$otherDispatcher = new EventDispatcher();

$dispatcher->addListener('event', 'Listener');
$otherDispatcher->addListener('other_event', 'OtherListener');
Copy link
Member Author
@GromNaN GromNaN Nov 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those 5 lines are useless. They should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@xabbuh xabbuh xabbuh approved these changes

@wouterj wouterj Awaiting requested review from wouterj

Assignees
No one assigned
Labels
Feature Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@GromNaN @javiereguiluz @xabbuh @carsonbot @stephenkhoo
0