[DependencyInjection][FrameworkBundle] Leverage array_is_list #44167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
reviewed
Nov 20, 2021
Contributor
There was a problem hiding this comment.
Looks like there is one more here: https://github.com/symfony/symfony/blob/5.4/src/Symfony/Component/Intl/Data/Bundle/Writer/TextBundleWriter.php#L84
derrabus
requested changes
Nov 20, 2021
Member
|
Looks like @fancyweb was a few seconds faster than me. 🙈 |
Member
Author
|
🤦 |
derrabus
approved these changes
Nov 20, 2021
fabpot
approved these changes
Nov 21, 2021
Member
|
Thank you @jderusse. |
fabpot
added a commit
that referenced
this pull request
Dec 15, 2021
This PR was merged into the 6.1 branch. Discussion ---------- [Intl] Leverage array_is_list | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | no | Deprecations? | - | Tickets | #44167 (review) | License | MIT | Doc PR | - It was forgotten in #44167 and this is the last occurrence in the code base 🙏 Commits ------- 575ebf2 [Intl] Leverage array_is_list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
array_is_listinstead ofcount+range+array_keytake over #44156