8000 Make ExpressionVoter Cacheable by jderusse · Pull Request #44096 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Make ExpressionVoter Cacheable #44096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2021
Merged

Make ExpressionVoter Cacheable #44096

merged 1 commit into from
Nov 17, 2021

Conversation

jderusse
Copy link
Member
Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

When making voters cacheable, I forgot to update the ExpressionVoter.

The ExpressionVoter only supports attributes that are an instance of Expression. So, the Expression does not support any attribute of type string.

FYI: When an attribute is not a string, the AccessDessision manager considers that all voters support it.

@carsonbot carsonbot added this to the 5.4 milestone Nov 16, 2021
@fabpot
Copy link
Member
fabpot commented Nov 17, 2021

Thank you @jderusse.

@fabpot fabpot merged commit 8ca777b into symfony:5.4 Nov 17, 2021
This was referenced Nov 18, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@wouterj wouterj Awaiting requested review from wouterj

Assignees
No one assigned
Labels
Feature Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@jderusse @fabpot @carsonbot
0