symfony · chalasr · Nov 15, 2021 · Nov 13, 2021
diff --git a/src/Symfony/Bridge/ProxyManager/Tests/LazyProxy/PhpDumper/ProxyDumperTest.php b/src/Symfony/Bridge/ProxyManager/Tests/LazyProxy/PhpDumper/ProxyDumperTest.php
@@ -196,6 +196,8 @@ function ($definition) {
 
 final class DummyClass implements DummyInterface, SunnyInterface
 {
+    private $ref;
+
     public function dummy()
     {
         return $this;

diff --git a/src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php b/src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php
@@ -253,7 +253,6 @@ public function testGetServiceIds()
     {
         $builder = new ContainerBuilder();
         $builder->register('foo', 'stdClass');
-        $builder->bar = $bar = new \stdClass();
         $builder->register('bar', 'stdClass');
         $this->assertEquals(
             [

diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/StdClassDecorator.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/StdClassDecorator.php
@@ -4,6 +4,8 @@
 
 final class StdClassDecorator
 {
+    public $foo;
+
     public function __construct(\stdClass $foo)
     {
         $this->foo = $foo;

diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/classes.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/classes.php
@@ -142,6 +142,8 @@ public static function create($config)
 
 class FoobarCircular
 {
+    public $foo;
+
     public function __construct(FooCircular $foo)
     {
         $this->foo = $foo;
@@ -150,6 +152,8 @@ public function __construct(FooCircular $foo)
 
 class FooCircular
 {
+    public $bar;
+
     public function __construct(BarCircular $bar)
     {
         $this->bar = $bar;
@@ -158,6 +162,8 @@ public function __construct(BarCircular $bar)
 
 class BarCircular
 {
+    public $foobar;
+
     public function addFoobar(FoobarCircular $foobar)
     {
         $this->foobar = $foobar;

diff --git a/src/Symfony/Component/EventDispatcher/Tests/EventDispatcherTest.php b/src/Symfony/Component/EventDispatcher/Tests/EventDispatcherTest.php
@@ -458,6 +458,7 @@ public function __invoke()
 
 class TestEventListener
 {
+    public $name;
     public $preFooInvoked = false;
     public $postFooInvoked = false;
 

diff --git a/src/Symfony/Component/HttpKernel/Tests/Fixtures/KernelForTest.php b/src/Symfony/Component/HttpKernel/Tests/Fixtures/KernelForTest.php
@@ -19,7 +19,7 @@ class KernelForTest extends Kernel
 {
     public function getBundleMap()
     {
-        return $this->bundleMap;
+        return [];
     }
 
     public function registerBundles(): iterable

diff --git a/src/Symfony/Component/Mime/Part/DataPart.php b/src/Symfony/Component/Mime/Part/DataPart.php
@@ -20,6 +20,9 @@
  */
 class DataPart extends TextPart
 {
+    /** @internal */
+    protected $_parent;
+
     private static $mimeTypes;
 
     private $filename;
@@ -32,6 +35,8 @@ class DataPart extends TextPart
      */
     public function __construct($body, string $filename = null, string $contentType = null, string $encoding = null)
     {
+        unset($this->_parent);
+
         if (null === $contentType) {
             $contentType = 'application/octet-stream';
         }

diff --git a/src/Symfony/Component/Mime/Part/SMimePart.php b/src/Symfony/Component/Mime/Part/SMimePart.php
@@ -18,6 +18,9 @@
  */
 class SMimePart extends AbstractPart
 {
+    /** @internal */
+    protected $_headers;
+
     private $body;
     private $type;
     private $subtype;
@@ -28,6 +31,8 @@ class SMimePart extends AbstractPart
      */
     public function __construct($body, string $type, string $subtype, array $parameters)
     {
+        unset($this->_headers);
+
         parent::__construct();
 
         if (!\is_string($body) && !is_iterable($body)) {

diff --git a/src/Symfony/Component/Mime/Part/TextPart.php b/src/Symfony/Component/Mime/Part/TextPart.php
@@ -23,6 +23,9 @@
  */
 class TextPart extends AbstractPart
 {
+    /** @internal */
+    protected $_headers;
+
     private static $encoders = [];
 
     private $body;
@@ -37,6 +40,8 @@ class TextPart extends AbstractPart
      */
     public function __construct($body, ?string $charset = 'utf-8', string $subtype = 'plain', string $encoding = null)
     {
+        unset($this->_headers);
+
         parent::__construct();
 
         if (!\is_string($body) && !\is_resource($body)) {

@@ -21,8 +21,17 @@
  */
 class AuthenticationException extends RuntimeException
 {
+    /** @internal */
+    protected $serialized;
+
     private $token;
 
+    public function __construct(string $message = '', int $code = 0, \Throwable $previous = null)
+    {
+        unset($this->serialized);
+        parent::__construct($message, $code, $previous);
+    }
+
     /**
      * Get the token.
      *

@@ -17,6 +17,8 @@
 
 class ChildCustomUserMessageAuthenticationException extends CustomUserMessageAuthenticationException
 {
+    public $childMember;
+
     public function __serialize(): array
     {
         return [$this->childMember, parent::__serialize()];

diff --git a/src/Symfony/Component/Validator/CHANGELOG.md b/src/Symfony/Component/Validator/CHANGELOG.md
@@ -96,7 +96,7 @@ CHANGELOG
 3.2.0
 -----
 
- * deprecated `Tests\Constraints\AbstractContraintValidatorTest` in favor of `Test\ConstraintValidatorTestCase`
+ * deprecated `Tests\Constraints\AbstractConstraintValidatorTest` in favor of `Test\ConstraintValidatorTestCase`
  * added support for PHP constants in YAML configuration files
 
 3.1.0

diff --git a/src/Symfony/Component/Validator/Constraint.php b/src/Symfony/Component/Validator/Constraint.php
@@ -25,8 +25,6 @@
  *
  * Constraint instances are immutable and serializable.
  *
- * @property string[] $groups The groups that the constraint belongs to
- *
  * @author Bernhard Schussek <bschussek@gmail.com>
  */
 abstract class Constraint
@@ -58,6 +56,13 @@ abstract class Constraint
      */
     public $payload;
 
+    /**
+     * The groups that the constraint belongs to.
+     *
+     * @var string[]
+     */
+    public $groups;
+
     /**
      * Returns the name of the given error code.
      *
@@ -105,14 +110,13 @@ public static function getErrorName($errorCode)
      */
     public function __construct($options = null)
     {
+        unset($this->groups); // enable lazy initialization
+
         $defaultOption = $this->getDefaultOption();
         $invalidOptions = [];
         $missingOptions = array_flip((array) $this->getRequiredOptions());
         $knownOptions = get_class_vars(static::class);
 
-        // The "groups" option is added to the object lazily
-        $knownOptions['groups'] = true;
-
         if (\is_array($options) && isset($options['value']) && !property_exists($this, 'value')) {
             if (null === $defaultOption) {
                 throw new ConstraintDefinitionException(sprintf('No default option is configured for constraint "%s".', static::class));

diff --git a/src/Symfony/Component/Validator/Constraints/Composite.php b/src/Symfony/Component/Validator/Constraints/Composite.php
@@ -79,7 +79,7 @@ public function __construct($options = null)
             }
         }
 
-        if (!property_exists($this, 'groups')) {
+        if (!isset(((array) $this)['groups'])) {
             $mergedGroups = [];
 
             foreach ($nestedConstraints as $constraint) {
@@ -96,7 +96,7 @@ public function __construct($options = null)
         }
 
         foreach ($nestedConstraints as $constraint) {
-            if (property_exists($constraint, 'groups')) {
+            if (isset(((array) $constraint)['groups'])) {
                 $excessGroups = array_diff($constraint->groups, $this->groups);
 
                if (\count($excessGroups) > 0) {
@@ -141,7 +141,7 @@ abstract protected function getCompositeOption();
      *
      * @return Constraint[]
      */
-    public function getNestedContraints()
+    public function getNestedConstraints()
     {
         /* @var Constraint[] $nestedConstraints */
         return $this->{$this->getCompositeOption()};

diff --git a/src/Symfony/Component/Validator/Mapping/ClassMetadata.php b/src/Symfony/Component/Validator/Mapping/ClassMetadata.php
@@ -490,8 +490,8 @@ private function checkConstraint(Constraint $constraint)
         }
 
         if ($constraint instanceof Composite) {
-            foreach ($constraint->getNestedContraints() as $nestedContraint) {
-                $this->checkConstraint($nestedContraint);
+            foreach ($constraint->getNestedConstraints() as $nestedConstraint) {
+                $this->checkConstraint($nestedConstraint);
             }
         }
     }

diff --git a/src/Symfony/Component/Validator/Mapping/MemberMetadata.php b/src/Symfony/Component/Validator/Mapping/MemberMetadata.php
@@ -188,8 +188,8 @@ private function checkConstraint(Constraint $constraint)
         }
 
         if ($constraint instanceof Composite) {
-            foreach ($constraint->getNestedContraints() as $<
10000
span class="x x-first x-last">nestedContraint
-                $this->checkConstraint($nestedContraint);
+            foreach ($constraint->getNestedConstraints() as $nestedConstraint) {
+                $this->checkConstraint($nestedConstraint);
             }
         }
     }

diff --git a/src/Symfony/Component/VarExporter/Internal/Exporter.php b/src/Symfony/Component/VarExporter/Internal/Exporter.php
@@ -286,7 +286,7 @@ private static function exportRegistry(Registry $value, string $indent, string $
         $r = '\\'.Registry::class;
         $j = -1;
 
-        foreach ($value as $k => $class) {
+        foreach ($value->classes as $k => $class) {
             if (':' === ($class[1] ?? null)) {
                 $serializables[$k] = $class;
                 continue;

diff --git a/src/Symfony/Component/VarExporter/Internal/Registry.php b/src/Symfony/Component/VarExporter/Internal/Registry.php
@@ -27,11 +27,11 @@ class Registry
     public static $cloneable = [];
     public static $instantiableWithoutConstructor = [];
 
+    public $classes = [];
+
     public function __construct(array $classes)
     {
-        foreach ($classes as $i => $class) {
-            $this->$i = $class;
-        }
+        $this->classes = $classes;
     }
 
     public static function unserialize($objects, $serializables)

diff --git a/src/Symfony/Component/VarExporter/Tests/VarExporterTest.php b/src/Symfony/Component/VarExporter/Tests/VarExporterTest.php
@@ -397,6 +397,8 @@ public function __construct()
 
 class Php74Serializable implements \Serializable
 {
+    public $foo;
+
     public function __serialize(): array
     {
         return [$this->foo = new \stdClass()];
-Original file line number
+Diff line change
@@ Expand Up / @@ -96,7 +96,7 @@ CHANGELOG @@
 .2.0
     -----
-     * deprecated `Tests\Constraints\AbstractContraintValidatorTest` in favor of `Test\ConstraintValidatorTestCase`
+     * deprecated `Tests\Constraints\AbstractConstraintValidatorTest` in favor of `Test\ConstraintValidatorTestCase`
      * added support for PHP constants in YAML configuration files
 .1.0
@@ Expand Down @@