[FrameworkBundle] fix registering late resettable services #43981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmikalkenas
reviewed
Nov 9, 2021
| @@ -146,7 +146,7 @@ public function build(ContainerBuilder $container) | |||
| $container->addCompilerPass(new CachePoolPrunerPass(), PassConfig::TYPE_AFTER_REMOVING); | |||
| $this->addCompilerPassIfExists($container, FormPass::class); | |||
| $container->addCompilerPass(new WorkflowGuardListenerPass()); | |||
| $container->addCompilerPass(new ResettableServicePass()); | |||
| $container->addCompilerPass(new ResettableServicePass(), PassConfig::TYPE_BEFORE_OPTIMIZATION, -32); | |||
There was a problem hiding this comment.
It would be good to also update ResettableServicePassTest with the same type and priority
ogizanagi
approved these changes
Nov 9, 2021
fabpot
approved these changes
Nov 10, 2021
|
Thank you @nicolas-grekas. |
This was referenced Nov 14, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResettableServicePassmust run after other passes that could potentially register more resettable services (egHttpClientPass)