10BC0 [PropertyInfo] Support the list pseudo-type by derrabus · Pull Request #43916 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[PropertyInfo] Support the list pseudo-type #43916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2021
Merged

[PropertyInfo] Support the list pseudo-type #43916

merged 1 commit into from
Nov 4, 2021

Conversation

@derrabus
Copy link
Member
@derrabus derrabus commented Nov 3, 2021 •
edited
Loading
Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #40142
License MIT
Doc PR N/A

This PR teaches PhpDocExtractor and PhpStanextractor to understand the generic list<> type. It also does some cleanup in both extractors.

@derrabus derrabus requested a review from dunglas as a code owner November 3, 2021 16:04
@carsonbot carsonbot added this to the 5.4 milestone Nov 3, 2021
@derrabus derrabus mentioned this pull request Nov 3, 2021
Closed
@derrabus derrabus force-pushed the improvement/list branch 4 times, most recently from 7db5a00 to d6ab527 8000 Compare November 3, 2021 17:30
nicolas-grekas
nicolas-grekas reviewed Nov 4, 2021
View reviewed changes
nicolas-grekas
nicolas-grekas approved these changes Nov 4, 2021
View reviewed changes
@derrabus derrabus merged commit 19db81c into symfony:5.4 Nov 4, 2021
@derrabus derrabus mentioned this pull request Nov 4, 2021
Closed
@derrabus derrabus deleted the improvement/list branch November 4, 2021 18:05
This was referenced Nov 5, 2021
Merged
Merged
@EmilMassey EmilMassey mentioned this pull request Dec 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees

No one assigned

Labels

Feature PropertyInfo Status: Reviewed

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

[PropertyInfo] Extend the allowed array syntax to list<> in PHPDoc

3 participants

@derrabus @nicolas-grekas @carsonbot
0