8000 [FrameworkBundle] Add types to private properties by derrabus · Pull Request #43869 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Add types to private properties #43869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2021
Merged

[FrameworkBundle] Add types to private properties #43869

merged 1 commit into from
Nov 2, 2021

Conversation

derrabus
Copy link
Member
@derrabus derrabus commented Nov 1, 2021
Q A
Branch? 6.0
Bug fix? no
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

@carsonbot carsonbot added this to the 6.0 milestone Nov 1, 2021
@derrabus derrabus mentioned this pull request Nov 1, 2021
Merged
@derrabus derrabus force-pushed the types/framework-bundle-properties branch 2 times, most recently from 88c87a8 to 4dad644 Compare November 1, 2021 18:00
nicolas-grekas added a commit that referenced this pull request Nov 2, 2021
@nicolas-grekas
minor #43871 [FrameworkBundle] Backport type fixes (derrabus)
2aff3c2 
This PR was merged into the 5.4 branch.

Discussion
----------

[FrameworkBundle] Backport type fixes

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Backports from #43869
| License       | MIT
| Doc PR        | N/A

Commits
-------

05d6ea7 [FrameworkBundle] Backport type fixes
@nicolas-grekas nicolas-grekas force-pushed the types/framework-bundle-properties branch from 4dad644 to 88220cf Compare November 2, 2021 10:55
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit c3ba8a4 into symfony:6.0 Nov 2, 2021
@derrabus derrabus deleted the types/framework-bundle-properties branch November 2, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@derrabus @nicolas-grekas @carsonbot
0