8000 remove no longer needed PHP version requirements from tests by xabbuh · Pull Request #43786 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

remove no longer needed PHP version requirements from tests #43786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2021
Merged

remove no longer needed PHP version requirements from tests #43786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
remove no longer needed PHP version requirements from tests
  • Loading branch information
@xabbuh
xabbuh committed Oct 27, 2021
commit bd76c058363b69cb381b88f129bc16cd399ffce3
3 changes: 0 additions & 3 deletions src/Symfony/Component/Console/Tests/Command/CommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,9 +420,6 @@ public function testCommandAttribute()
$this->assertSame(['f'], $command->getAliases());
}

/**
* @requires PHP 8
*/
public function testDefaultCommand()
{
$apl = new Application();
Expand Down
27 changes: 0 additions & 27 deletions src/Symfony/Component/DependencyInjection/Tests/Compiler/IntegrationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,9 +384,6 @@ public function testTaggedServiceWithIndexAttributeAndDefaultMethodConfiguredVia
$this->assertSame(['bar_tab_class_with_defaultmethod' => $container->get(BarTagClass::class), 'foo' => $container->get(FooTagClass::class)], $param);
}

/**
* @requires PHP 8
*/
public function testTaggedIteratorWithDefaultIndexMethodConfiguredViaAttribute()
{
$container = new ContainerBuilder();
Expand All @@ -411,9 +408,6 @@ public function testTaggedIteratorWithDefaultIndexMethodConfiguredViaAttribute()
$this->assertSame(['bar_tag_class' => $container->get(BarTagClass::class), 'foo_tag_class' => $container->get(FooTagClass::class)], $param);
}

/**
* @requires PHP 8
*/
public function testTaggedIteratorWithDefaultPriorityMethodConfiguredViaAttribute()
{
$container = new ContainerBuilder();
Expand All @@ -438,9 +432,6 @@ public function testTaggedIteratorWithDefaultPriorityMethodConfiguredViaAttribut
$this->assertSame([0 => $container->get(FooTagClass::class), 1 => $container->get(BarTagClass::class)], $param);
}

/**
* @requires PHP 8
*/
public function testTaggedIteratorWithDefaultIndexMethodAndWithDefaultPriorityMethodConfiguredViaAttribute()
{
$container = new ContainerBuilder();
Expand Down Expand Up @@ -491,9 +482,6 @@ public function testTaggedLocatorConfiguredViaAttribute()
self::assertSame($container->get(FooTagClass::class), $locator->get('foo'));
}

/**
* @requires PHP 8
*/
public function testTaggedLocatorConfiguredViaAttributeWithoutIndex()
{
$container = new ContainerBuilder();
Expand All @@ -520,9 +508,6 @@ public function testTaggedLocatorConfiguredViaAttributeWithoutIndex()
self::assertSame($container->get(FooTagClass::class), $locator->get(FooTagClass::class));
}

/**
* @requires PHP 8
*/
public function testTaggedLocatorWithDefaultIndexMethodConfiguredViaAttribute()
{
$container = new ContainerBuilder();
Expand All @@ -549,9 +534,6 @@ public function testTaggedLocatorWithDefaultIndexMethodConfiguredViaAttribute()
self::assertSame($container->get(FooTagClass::class), $locator->get('foo_tag_class'));
}

/**
* @requires PHP 8
*/
public function testTaggedLocatorWithDefaultPriorityMethodConfiguredViaAttribute()
{
$container = new ContainerBuilder();
Expand Down Expand Up @@ -582,9 +564,6 @@ public function testTaggedLocatorWithDefaultPriorityMethodConfiguredViaAttribute
self::assertSame([FooTagClass::class, BarTagClass::class], array_keys($factories->getValue($locator)));
}

/**
* @requires PHP 8
*/
public function testTaggedLocatorWithDefaultIndexMethodAndWithDefaultPriorityMethodConfiguredViaAttribute()
{
$container = new ContainerBuilder();
Expand Down Expand Up @@ -617,9 +596,6 @@ public function testTaggedLocatorWithDefaultIndexMethodAndWithDefaultPriorityMet
self::assertSame($container->get(FooTagClass::class), $locator->get('foo_tag_class'));
}

/**
* @requires PHP 8
*/
public function testNestedDefinitionWithAutoconfiguredConstructorArgument()
{
$container = new ContainerBuilder();
Expand Down Expand Up @@ -904,9 +880,6 @@ static function (Definition $definition, CustomAutoconfiguration $attribute) {
], $collector->collectedTags);
}

/**
* @requires PHP 8
*/
public function testTagsViaAttributeOnPropertyMethodAndParameter()
{
$container = new ContainerBuilder();
Expand Down
3 changes: 0 additions & 3 deletions src/Symfony/Component/HttpKernel/Tests/ControllerMetadata/ArgumentMetadataFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,6 @@ public function testMultipleAttributes()
$this->assertCount(1, $this->factory->createArgumentMetadata([new AttributeController(), 'multiAttributeArg'])[0]->getAttributes());
}

/**
* @requires PHP 8
*/
public function testIssue41478()
{
$arguments = $this->factory->createArgumentMetadata([new AttributeController(), 'issue41478']);
Expand Down
3 changes: 0 additions & 3 deletions src/Symfony/Component/Messenger/Tests/DependencyInjection/MessengerPassTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,6 @@ public function testFromTransportViaTagAttribute()
$this->assertHandlerDescriptor($container, $handlerDescriptionMapping, DummyMessage::class, [DummyHandler::class], [['from_transport' => 'async']]);
}

/**
* @requires PHP 8
*/
public function testTaggedMessageHandler()
{
$container = $this->getContainerBuilder($busId = 'message_bus');
Expand Down
1 change: 0 additions & 1 deletion src/Symfony/Component/Serializer/Tests/SerializerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -997,7 +997,6 @@ public function testCollectDenormalizationErrors2()
$this->assertSame($expected, $exceptionsAsArray);
}

/** @requires PHP 8.0 */
public function testCollectDenormalizationErrorsWithConstructor()
{
$json = '{"bool": "bool"}';
Expand Down
3 changes: 0 additions & 3 deletions src/Symfony/Component/Validator/Tests/Constraints/CidrTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,6 @@ public function getValidMinMaxValues(): array
];
}

/**
* @requires PHP 8
*/
public function testAttributes()
{
$metadata = new ClassMetadata(CidrDummy::class);
Expand Down
1 change: 0 additions & 1 deletion src/Symfony/Component/Validator/Tests/Constraints/CssColorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

/**
* @author Mathieu Santostefano <msantostefano@protonmail.com>
* @requires PHP 8
*/
final class CssColorTest extends TestCase
{
Expand Down
0