8000 [FrameworkBundle] Add completion for config:dump-reference by StaffNowa · Pull Request #43682 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[FrameworkBundle] Add completion for config:dump-reference #43682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2021
Merged

[FrameworkBundle] Add completion for config:dump-reference #43682

merged 1 commit into from
Oct 26, 2021

Conversation

StaffNowa
Copy link
Contributor
Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets #43594
License MIT
Doc PR -

Add completion for config:dump-reference

@carsonbot carsonbot added this to the 5.4 milestone Oct 24, 2021
@carsonbot carsonbot changed the title Add completion for config:dump-reference [FrameworkBundle] Add completion for config:dump-reference Oct 24, 2021
@fabpot
Copy link
Member
fabpot commented Oct 26, 2021

Thank you @StaffNowa.

public function complete(CompletionInput $input, CompletionSuggestions $suggestions): void
{
if ($input->mustSuggestArgumentValuesFor('name')) {
$suggestions->suggestValues($this->getAvailableBundles());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StaffNowa @fabpot isnt missing a return here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noniagriconomie I think all good here.

@StaffNowa StaffNowa deleted the feature/config-dump-reference branch October 26, 2021 15:26
This was referenced Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0