8000 [Console] fix tests on Windows by xabbuh · Pull Request #43657 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] fix tests on Windows #43657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2021
Merged

[Console] fix tests on Windows #43657

merged 1 commit into from
Oct 25, 2021

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Oct 22, 2021 •
edited
Loading
Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 5.4 milestone Oct 22, 2021
@xabbuh xabbuh requested a review from chalasr as a code owner October 22, 2021 14:20
@xabbuh xabbuh force-pushed the console-tests-windows branch 5 times, most recently from f0eea37 to b7f361a Compare October 22, 2021 15:02
@carsonbot
Copy link

Hey!

I think @LukeTowers has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@wouterj
Copy link
Member
wouterj commented Oct 23, 2021

Ooh, I guess maybe Windows breaks the json with the \ directory separator? thanks for investigating this!

@xabbuh xabbuh force-pushed the console-tests-windows branch 6 times, most recently from bf2ee31 to bc0cffa Compare October 25, 2021 13:08
@xabbuh xabbuh changed the title debug Console test failures on Windows [Console] fix tests on Windows Oct 25, 2021
@xabbuh xabbuh force-pushed the console-tests-windows branch 2 times, most recently from f06ef6a to 1fc2e5b Compare October 25, 2021 13:18
@xabbuh xabbuh force-pushed the console-tests-windows branch from 1fc2e5b to 8c41e06 Compare October 25, 2021 13:20
@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 4612991 into symfony:5.4 Oct 25, 2021
@xabbuh xabbuh deleted the console-tests-windows branch October 25, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Console Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @carsonbot @wouterj @nicolas-grekas @fabpot
0