[Console] Add completion to messenger:setup-transports command #43640
Conversation
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | #43594 |
| License | MIT |
| Doc PR | no |
- Add completion for command messenger:setup-transports (transport)
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
| if (!$input->mustSuggestArgumentValuesFor('transport')) { | ||
| return; | ||
| } | ||
|
|
||
| $suggestions->suggestValues($this->transportNames); |
There was a problem hiding this comment.
| if (!$input->mustSuggestArgumentValuesFor('transport')) { | |
| return; | |
| } | |
| $suggestions->suggestValues($this->transportNames); | |
| if (!$input->mustSuggestArgumentValuesFor('transport')) { | |
| $suggestions->suggestValues($this->transportNames); | |
| return; | |
| } |
While normally, we favor "early return" in the Symfony code base, I propose to not do that in the complete() methods. This way, we minimize the diff (and potential merge conflicts) when we add more completion suggestions to this method in a future version.
| */ | ||
| public function testComplete(array $input, array $expectedSuggestions) | ||
| { | ||
| /** @var MockObject&ServiceLocator $serviceLocator */ |
There was a problem hiding this comment.
| /** @var MockObject&ServiceLocator $serviceLocator */ |
199626a to
e78aafe
Compare
e78aafe to
733aaa8
Compare
|
Thank you @Tayfun74. |