8000 UniqueEntityValidator: Retrieve at max two entities to check uniqueness. by AndreasA · Pull Request #43611 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

UniqueEntityValidator: Retrieve at max two entities to check uniqueness. #43611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2021
Merged

UniqueEntityValidator: Retrieve at max two entities to check uniqueness. #43611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Symfony/Bridge/Doctrine/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ CHANGELOG

* Add `DoctrineOpenTransactionLoggerMiddleware` to log when a transaction has been left open
* Deprecate `PdoCacheAdapterDoctrineSchemaSubscriber` and add `DoctrineDbalCacheAdapterSchemaSubscriber` instead
* `UniqueEntity` constraint retrieves a maximum of two entities if the default repository method is used.

5.3
---
Expand Down
13 changes: 12 additions & 1 deletion src/Symfony/Bridge/Doctrine/Validator/Constraints/UniqueEntityValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,18 @@ public function validate($entity, Constraint $constraint)
$repository = $em->getRepository(\get_class($entity));
}

$result = $repository->{$constraint->repositoryMethod}($criteria);
$arguments = [$criteria];

/* If the default repository method is used, it is always enough to retrieve at most two entities because:
* - No entity returned, the current entity is definitely unique.
* - More than one entity returned, the current entity cannot be unique.
* - One entity returned the uniqueness depends on the current entity.
*/
if ('findBy' === $constraint->repositoryMethod) {
$arguments = [$criteria, null, 2];
}

$result = $repository->{$constraint->repositoryMethod}(...$arguments);

if ($result instanceof \IteratorAggregate) {
$result = $result->getIterator();
Expand Down
0