8000 [Validator] Update validators.sr_Cyrl.xlf by juricav · Pull Request #43477 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Validator] Update validators.sr_Cyrl.xlf #43477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2021
Merged

Conversation

juricav
Copy link
Contributor
@juricav juricav commented Oct 13, 2021
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #43453
License MIT
Doc PR symfony/symfony-docs#...

Add missing translation.

@carsonbot carsonbot added this to the 4.4 milestone Oct 13, 2021
@carsonbot carsonbot changed the title Update validators.sr_Cyrl.xlf [Validator] Update validators.sr_Cyrl.xlf Oct 13, 2021
@fabpot
Copy link
Member
fabpot commented Oct 13, 2021

@juricav Thank you for all your PRs. Can you confirm that you are you speak all languages you've contributed to fluently? We tend to prefer native speakers for each language.

@juricav
Copy link
Contributor Author
juricav commented Oct 13, 2021

@fabpot hi, I'm a native speaker of Croatian, but I'm fluent in others I've contributed to because they are in the same family of languages.

@@ -16,7 +16,7 @@
</trans-unit>
<trans-unit id="99">
<source>This value is not a valid HTML5 color.</source>
<target>Ова вредност није исправна HTML5 боја.</target>
<target>Ова вредност није валидна HTML5 боја.</target>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest of the translation (mostly) uses adjective исправан instead of валидан

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaznovac I was between those two words for the previous commit and have chosen валидан because it seemed more fitting for a thing like HTML5 or CSS that has a pretty clear valid and invalid "state".
Does that make sense for you or you believe I should rather stay with исправан?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use исправан since those two words are synonyms, and исправан was used in both variants of Serbian translation so far.

@fabpot
Copy link
Member
fabpot commented Oct 24, 2021

Thank you @juricav.

@fabpot fabpot merged commit 5eef649 into symfony:4.4 Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0