-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Validator] Update validators.sr_Cyrl.xlf #43477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@juricav Thank you for all your PRs. Can you confirm that you are you speak all languages you've contributed to fluently? We tend to prefer native speakers for each language. |
@fabpot hi, I'm a native speaker of Croatian, but I'm fluent in others I've contributed to because they are in the same family of languages. |
@@ -16,7 +16,7 @@ | |||
</trans-unit> | |||
<trans-unit id="99"> | |||
<source>This value is not a valid HTML5 color.</source> | |||
<target>Ова вредност није исправна HTML5 боја.</target> | |||
<target>Ова вредност није валидна HTML5 боја.</target> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the rest of the translation (mostly) uses adjective исправан
instead of валидан
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaznovac I was between those two words for the previous commit and have chosen валидан
because it seemed more fitting for a thing like HTML5 or CSS that has a pretty clear valid and invalid "state".
Does that make sense for you or you believe I should rather stay with исправан
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use исправан
since those two words are synonyms, and исправан
was used in both variants of Serbian translation so far.
Thank you @juricav. |
Add missing translation.