8000 [HttpKernel] Fix incorrect invalid message and change range to compare by JohJohan · Pull Request #43399 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] Fix incorrect invalid message and change range to compare #43399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2021
Merged

[HttpKernel] Fix incorrect invalid message and change range to compare #43399

merged 1 commit into from
Oct 13, 2021

Conversation

JohJohan
Copy link
Contributor
@JohJohan JohJohan commented Oct 11, 2021 •
edited
Loading
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

Fix invlid config message and change range to two comparisons
#42244 (comment)

@carsonbot carsonbot added this to the 5.4 milestone Oct 11, 2021
@JohJohan JohJohan mentioned this pull request Oct 11, 2021
Merged
Ahummeling
Ahummeling reviewed Oct 11, 2021
View reviewed changes
Copy link
Contributor
@Ahummeling Ahummeling left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, got 1 small remark

@Ahummeling
Copy link
Contributor

Additionally, seems like 1 of the tests is failing. Perhaps there's a testcase that explicitly asserts the messages are equal, this expected message should be updated as well.

@JohJohan
[HttpKernel] Fix incorrect invalid message and change range to compare
e5a7f83 
[HttpKernel] Allow all http status codes and change invalid message
@JohJohan JohJohan force-pushed the improve-check-and-message branch from 359fe84 to e5a7f83 Compare October 12, 2021 18:25
@fabpot
Copy link
Member
fabpot commented Oct 13, 2021

Thank you @JohJohan.

@fabpot fabpot merged commit 21cc2b6 into symfony:5.4 Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgalopin tgalopin tgalopin left review comments

@Ahummeling Ahummeling Ahummeling left review comments

fabpot approved these changes

@lyrixx lyrixx lyrixx approved these changes

Assignees
No one assigned
Labels
Bug HttpKernel Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
6 participants
@JohJohan @Ahummeling @fabpot @lyrixx @tgalopin @carsonbot
0