[2.1][Component][Finder] $this->current() fix #4335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably it should go to master branch, because it improves commit done to master: |
| $iterator = new FilecontentFilterIterator($inner, array('file r+'), array()); | ||
| $array = iterator_to_array($iterator); | ||
| } | ||
|
|
||
| } | ||
|
|
||
| class ContentInnerNameIterator extends \ArrayIterator | ||
| class FauxFile extends \SplFileInfo |
There was a problem hiding this comment.
Faux => not real. MockFile will be better? Maybe MockSplFileInfo?
| * | ||
| * @return string the contents of the file | ||
| */ | ||
| public function fileGetContents() |
| $error = error_get_last(); | ||
| throw new \RuntimeException($error['message']); | ||
| } | ||
| return $content; |
There was a problem hiding this comment.
missing empty line before the return statement
|
seems good |
fabpot
added a commit
that referenced
this pull request
Jun 19, 2012
Commits ------- 3eb67fc [2.1][Component][Finder] $this->current() fix Discussion ---------- [2.1][Component][Finder] $this->current() fix Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: [](http://travis-ci.org/gajdaw/symfony) Fixes the following tickets: - Todo: - License of the code: MIT One method to resolve `->in("ftp://...")` problem is to create `RecursiveDirectoryFtpIterator`. (Details: [issue 3585](#3585)) I think that all filters should access the information about current item calling `current()` or `getInnerIterator()`. Otherwise it will not work if we replace `RecursiveDirectoryIterator` with ftp iterator inside `Finder`. I'm not sure if that should go to 2.0 or 2.1 branch. --------------------------------------------------------------------------- by travisbot at 2012-05-19T09:20:19Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1373361) (merged 9f247921 into 58b9245). --------------------------------------------------------------------------- by gajdaw at 2012-05-19T10:51:10Z Probably it should go to master branch, because it improves commit done to master: f2fea97 --------------------------------------------------------------------------- by travisbot at 2012-05-19T11:26:14Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1373982) (merged f9d1db8c into 58b9245). --------------------------------------------------------------------------- by travisbot at 2012-05-19T11:51:25Z This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1374031) (merged f1b4b4f7 into 58b9245). --------------------------------------------------------------------------- by travisbot at 2012-05-19T12:48:17Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1374303) (merged b6d073da into 58b9245). --------------------------------------------------------------------------- by travisbot at 2012-05-19T13:28:18Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1374568) (merged fd144c96 into 58b9245). --------------------------------------------------------------------------- by travisbot at 2012-05-19T13:35:38Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1374609) (merged 89a8d851 into 58b9245). --------------------------------------------------------------------------- by travisbot at 2012-05-21T04:31:46Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1385764) (merged 0d5b8322 into 58b9245). --------------------------------------------------------------------------- by travisbot at 2012-05-21T07:21:56Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1386545) (merged 3eb67fc into 1407f11). --------------------------------------------------------------------------- by stof at 2012-06-09T13:24:14Z seems good
| public function getContents() | ||
| { | ||
| $level = error_reporting(0); | ||
| $content = file_get_contents($this->getRealpath()); |
There was a problem hiding this comment.
Use openFile and SplFileObject::fpassthu
There was a problem hiding this comment.
@stealth35 Do you mean something like https://github.com/gajdaw/symfony/commit/5b3501acdca3097331a5adf1d239d448863ddc8d ?
|
As of the latest pull, using an FTP stream wrapper still respond with a warning: "PHP Warning: FilesystemIterator::rewind(): stream does not support seeking", and misses the first file in every folder |
|
@housebolt Please open a ticket instead of commenting on a PR merged 4 months ago (as this would be lost) |
|
@stof, am in the process of putting together a ticket, just making it known for those who run into the same issue and come across this thread, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass:
Fixes the following tickets: -
Todo: -
License of the code: MIT
One method to resolve
->in("ftp://...")problem is to createRecursiveDirectoryFtpIterator.(Details: issue 3585)
I think that all filters should access the information about current item calling
current()orgetInnerIterator(). Otherwise it will not work if we replaceRecursiveDirectoryIteratorwith ftp iterator insideFinder.I'm not sure if that should go to 2.0 or 2.1 branch.