[Mailer] Improve error message when STARTTLS fails #43238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
derrabus
approved these changes
Sep 28, 2021
stof
reviewed
Sep 28, 2021
| throw new TransportException('Unable to connect with STARTTLS: '.$msg); | ||
| }); | ||
| try { | ||
| return stream_socket_enable_crypto($this->stream, true); |
There was a problem hiding this comment.
you remove the (bool) cast. Is it expected ?
There was a problem hiding this comment.
the function returns int only when a non blocking stream is passes, which is never the case here and would be unsupported anyway
fabpot
approved these changes
Sep 28, 2021
|
Thank you @nicolas-grekas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
3013
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.