8000 [Messenger] Add types to private properties by derrabus · Pull Request #43195 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] Add types to private properties #43195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2021
Merged

[Messenger] Add types to private properties #43195

merged 1 commit into from
Oct 30, 2021

Conversation

derrabus
Copy link
Member
@derrabus derrabus commented Sep 27, 2021 •
edited
Loading
Q A
Branch? 6.0
Bug fix? no
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

@derrabus derrabus requested a review from sroze as a code owner September 27, 2021 11:51
@carsonbot carsonbot added this to the 6.0 milestone Sep 27, 2021
@derrabus derrabus force-pushed the types/messenger-types branch 2 times, most recently from 9ea3ae5 to b2ea115 Compare September 27, 2021 12:08
@derrabus derrabus mentioned this pull request Sep 27, 2021
Merged
@derrabus derrabus force-pushed the types/messenger-types branch from b2ea115 to 22940d8 Compare September 27, 2021 12:40
derrabus added a commit that referenced this pull request Sep 27, 2021
@derrabus
minor #43196 [Messenger] Backport type fixes (derrabus)
28567f3 
This PR was merged into the 5.4 branch.

Discussion
----------

[Messenger] Backport type fixes

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Backports from #43195
| License       | MIT
| Doc PR        | N/A

Commits
-------

65ec8f9 [Messenger] Backport type fixes
@derrabus derrabus force-pushed the types/messenger-types branch from 22940d8 to 41d3f28 Compare September 27, 2021 14:25
@carsonbot
Copy link

Hey!

I think @X-Coder264 has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot
< 8000 div class="pr-review-reactions ">

@fabpot
Copy link
Member
fabpot commented Oct 30, 2021

What about this one? It needs a rebase for sure at least.

@derrabus
Copy link
Member Author

I'll do the rebase.

@derrabus derrabus force-pushed the types/messenger-types branch from 41d3f28 to ae4dd89 Compare October 30, 2021 13:34
@derrabus
Copy link
Member Author

Rebased and updated. PR is ready again.

@derrabus derrabus force-pushed the types/messenger-types branch 2 times, most recently from 78bfb23 to c0b2961 Compare October 30, 2021 13:50
@derrabus
[Messenger] Add types to private properties
6450840 
Signed-off-by: Alexander M. Turek <me@derrabus.de>
@derrabus derrabus force-pushed the types/messenger-types branch from c0b2961 to 6450840 Compare October 30, 2021 13:51
@fabpot
Copy link
Member
fabpot commented Oct 30, 2021

Thank you @derrabus.

@fabpot fabpot merged commit 9015fea into symfony:6.0 Oct 30, 2021
@derrabus derrabus deleted the types/messenger-types branch October 30, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Messenger Status: Reviewed
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@derrabus @carsonbot @fabpot @nicolas-grekas
0