8000 [Notifier] Add sms77 Notifier Bridge by matthiez · Pull Request #43134 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Notifier] Add sms77 Notifier Bridge #43134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and 8000 privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[Notifier] Add sms77 Notifier Bridge #43134

wants to merge 4 commits into from

Conversation

matthiez
Copy link
Contributor
Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
License MIT
Doc PR symfony/symfony-docs/pull/15840
Recipe PR symfony/recipes/pull/1003

Add sms77 bridge to Symfony Notifier.
A Germany based SMS provider established in 2003.

@carsonbot carsonbot added this to the 5.4 milestone Sep 22, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

I think @qdequippe has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

OskarStark
OskarStark requested changes Sep 25, 2021
View reviewed changes
Copy link
Contributor
@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some minor things

matthiez and others added 2 commits September 28, 2021 13:40
@matthiez
[Notifier] Fix typos for Sms77 README.md
33d81e7 
Fix typos in src/Symfony/Component/Notifier/Bridge/Sms77/README.md
@matthiez @OskarStark
[Notifier] Fix typo in Sms77TransportFactoryTest
13a96ed 
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
@OskarStark
Copy link
Contributor

Please check fabbot and fix the coding standards. Thanks

@Nyholm Nyholm added the Ready label Oct 11, 2021
@fabpot
Copy link
Member
fabpot commented Oct 13, 2021

Thank you @matthiez.

fabpot added a commit that referenced this pull request Oct 13, 2021
@fabpot
feature #43134 [Notifier] Add sms77 Notifier Bridge (matthiez)
a8a57a1 
This PR was squashed before being merged into the 5.4 branch.

Discussion
----------

[Notifier] Add sms77 Notifier Bridge

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| License       | MIT
| Doc PR        | [symfony/symfony-docs/pull/15840](symfony/symfony-d
AE22
ocs#15840)
| Recipe PR | [symfony/recipes/pull/1003](symfony/recipes#1003)

Add sms77 bridge to Symfony Notifier.
A Germany based SMS provider established in 2003.

Commits
-------

6d5be78 [Notifier] Add sms77 Notifier Bridge
@fabpot fabpot closed this Oct 13, 2021
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@OskarStark OskarStark OskarStark approved these changes

@qdequippe qdequippe qdequippe approved these changes

@derrabus derrabus Awaiting requested review from derrabus

@Nyholm Nyholm Awaiting requested review from Nyholm

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

Assignees
No one assigned
Labels
Feature Notifier Ready Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
7 participants
@matthiez @carsonbot @OskarStark @fabpot @javiereguiluz @qdequippe @Nyholm
0