8000 [Ldap] Add types to private properties by derrabus · Pull Request #42930 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Ldap] Add types to private properties #42930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2021
Merged

[Ldap] Add types to private properties #42930

merged 1 commit into from
Sep 8, 2021

Conversation

derrabus
Copy link
Member
@derrabus derrabus commented Sep 8, 2021
Q A
Branch? 6.0
Bug fix? no
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

@carsonbot carsonbot added this to the 6.0 milestone Sep 8, 2021
@nicolas-grekas
Copy link
Member

fabbot has a catch :) (will you backport some changes to 5.4 after merge or do you prefer to create the PR for 5.4 before?)

@derrabus derrabus force-pushed the types/ldap-properties branch from 0a6f309 to 9ebd9f8 Compare September 8, 2021 10:44
@derrabus
Copy link
Member Author
derrabus commented Sep 8, 2021

I'll do the backports once the integration tests are green. I don't have an LDAP setup, so I'm abusing GHA at the moment. 🙈

@derrabus derrabus force-pushed the types/ldap-properties branch from 9ebd9f8 to 6768837 Compare September 8, 2021 10:53
@derrabus derrabus mentioned this pull request Sep 8, 2021
Merged
@derrabus
Copy link
Member Author
derrabus commented Sep 8, 2021

Backports: #42931

nicolas-grekas added a commit that referenced this pull request Sep 8, 2021
@nicolas-grekas
minor #42931 [Ldap] Backport refactorings (derrabus)
8b8a5eb 
This PR was merged into the 5.4 branch.

Discussion
----------

[Ldap] Backport refactorings

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Backports from #42930
| License       | MIT
| Doc PR        | N/A

Commits
-------

4d59096 [Ldap] Backport refactorings
@derrabus derrabus force-pushed the types/ldap-properties branch from 6768837 to 03b97c8 Compare September 8, 2021 12:28
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit 3aa3b9d into symfony:6.0 Sep 8, 2021
@derrabus derrabus deleted the types/ldap-properties branch September 8, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

Assignees
No one assigned
Labels
Ldap Status: Needs Review
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@derrabus @nicolas-grekas @carsonbot
0