8000 [HttpKernel] Fix empty timeline in profiler by nicodmf · Pull Request #42830 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] Fix empty timeline in profiler #42830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2021
Merged

[HttpKernel] Fix empty timeline in profiler #42830

merged 1 commit into from
Sep 1, 2021

Conversation

nicodmf
Copy link
Contributor
@nicodmf nicodmf commented Sep 1, 2021 •
edited
Loading

Simple fix to #42804

Q A
Branch? 5.3 && 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #42804
License MIT

Fix #42804 following #42331 conventions

Another solution could be found here #42823

@carsonbot carsonbot added this to the 4.4 milestone Sep 1, 2021
@herndlm
Copy link
Contributor
herndlm commented Sep 1, 2021

Maybe yours is the better one, I honestly don't know, I'll link it in my PR too.

@herndlm herndlm mentioned this pull request Sep 1, 2021
Closed
@fabpot
Copy link
Member
fabpot commented Sep 1, 2021

Thank you @nicodmf.

@fabpot fabpot merged commit ced4415 into symfony:4.4 Sep 1, 2021
@Mausino
Copy link
Mausino commented Sep 1, 2021

Thank you guys :) i can confirm that fix issue in timeline in profiler on my instance 👍

This was referenced Sep 28, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug HttpKernel Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@nicodmf @herndlm @fabpot @Mausino @carsonbot
0