8000 Cast ini_get to an integer to match expected type by natewiebe13 · Pull Request #42753 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Cast ini_get to an integer to match expected type #42753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Cast ini_get to an integer to match expected type #42753

wants to merge 0 commits into from

Conversation

natewiebe13
Copy link
Contributor
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

The lifetime value is expected to be an integer, but this is set as a string when using the ini value from session.cookie_lifetime. This makes getLifetime() return a string instead of an int as the @return states.

@carsonbot carsonbot added this to the 4.4 milestone Aug 26, 2021
jderusse
jderusse reviewed Aug 26, 2021
View reviewed changes
Copy link
Member
@jderusse jderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please provide a test?

@natewiebe13
Copy link
Contributor Author

Could you please provide a test?

Added.

@fabpot
Copy link
Member
fabpot commented Aug 26, 2021

Thank you @natewiebe13.

@fabpot fabpot closed this Aug 26, 2021
fabpot added a commit that referenced this pull request Aug 26, 2021
@fabpot
bug #42753 Cast ini_get to an integer to match expected type (natewie…
ecf55ab 
…be13)

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

Cast ini_get to an integer to match expected type

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

The lifetime value is expected to be an integer, but this is set as a string when using the ini value from `session.cookie_lifetime`. This makes `getLifetime()` return a string instead of an int as the ``@return`` states.

Commits
-------

c56470d Cast ini_get to an integer to match expected type
@fabpot fabpot force-pushed the fix-incorrect-type branch from bc9ec63 to c56470d Compare August 26, 2021 15:51
@natewiebe13 natewiebe13 deleted the fix-incorrect-type branch August 26, 2021 15:51
This was referenced Aug 30, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@stof stof stof approved these changes

@jderusse jderusse jderusse approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@natewiebe13 @fabpot @stof @jderusse @carsonbot
0