[WebProfilerBundle] Ajusted the color of the PHP logo #4270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the redesign of the Web-Debug-Toolbar, a new PHP icon has been set, but its color was a bit darker (#000000) than the other icons in the toolbar (#302e32 for the Symfony2 logo). This commit aims to ajust the background color of the PHP logo to keep a certain homogeneity.
fabpot
added a commit
that referenced
this pull request
May 13, 2012
Commits ------- 9f772c7 [WDT] Ajusted the color of the PHP logo Discussion ---------- [WebProfilerBundle] Ajusted the color of the PHP logo Since the redesign of the Web-Debug-Toolbar in #3850, a new PHP icon has been added, but its color is a bit darker (`#000000`) than the other icons in the toolbar (`#302e32` for the Symfony2 logo). @stloyd also noticed it [here](#3850 (comment)). This (minor) PR aims to ajust the background color of the PHP logo to keep a certain homogeneity. The color change can be see there (before/after) : http://twitpic.com/9kbs4p --------------------------------------------------------------------------- by travisbot at 2012-05-12T21:03:31Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1316131) (merged 9f772c7 into e193452).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the redesign of the Web-Debug-Toolbar in #3850, a new PHP icon has been added, but its color is a bit darker (
#000000) than the other icons in the toolbar (#302e32for the Symfony2 logo). @stloyd also noticed it here.This (minor) PR aims to ajust the background color of the PHP logo to keep a certain homogeneity.
The color change can be see there (before/after) : http://twitpic.com/9kbs4p