8000 Fix deprecation messages by fabpot · Pull Request #42534 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fix deprecation messages #42534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2021
Merged

Fix deprecation messages #42534

merged 1 commit into from
Aug 13, 2021

Conversation

fabpot
Copy link
Member
@fabpot fabpot commented Aug 13, 2021 •
edited
Loading
Q A
Branch? 5.3
Bug fix? no
New feature? no
Deprecations? no
Tickets n/A
License MIT
Doc PR n/a

For consistency (200 messages use Symfony, 50 do not yet).

@fabpot fabpot requested review from chalasr and wouterj as code owners August 13, 2021 15:55
@carsonbot carsonbot added this to the 5.3 milestone Aug 13, 2021
@fabpot fabpot mentioned this pull request Aug 13, 2021
Merged
@fabpot fabpot merged commit 785a6ab into symfony:5.3 Aug 13, 2021
@fabpot fabpot deleted the deprecation-messages-53 branch August 13, 2021 15:58
@chalasr
Copy link
Member
chalasr commented Aug 13, 2021

A fabbot rule ensuring that any @deprecated since has the right format would be quite useful 😇

@fabpot fabpot mentioned this pull request Aug 13, 2021
Merged
fabpot added a commit that referenced this pull request Aug 13, 2021
@fabpot
minor #42535 Fix deprecation messages (fabpot)
c939ea1 
This PR was merged into the 5.4 branch.

Discussion
----------

Fix deprecation messages

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/A <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | n/a

#42534 for 5.4.

Commits
-------

f95b41f Fix deprecation messages
@fabpot
Copy link
Member Author
fabpot commented Aug 13, 2021

@chalasr Done, should be ok for the next PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr approved these changes

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@fabpot @chalasr @carsonbot
0