8000 [Mailer] Fixed decode exception when sendgrid response is 202 by rubanooo · Pull Request #42307 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Mailer] Fixed decode exception when sendgrid response is 202 #42307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2021
Merged

[Mailer] Fixed decode exception when sendgrid response is 202 #42307

merged 1 commit into from
Jul 29, 2021

Conversation

rubanooo
Copy link
Contributor
Q A
Branch? 5.4 for features / 4.4, 5.2 or 5.3 for bug fixes
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #42306
License MIT
Doc PR symfony/symfony-docs#...

< 8000 div class="TimelineItem js-targetable-element" data-team-hovercards-enabled id="event-5079410315">
@carsonbot carsonbot added this to the 5.3 milestone Jul 28, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@derrabus derrabus requested a review from Nyholm July 28, 2021 11:13
@derrabus
Copy link
Member

We need to target 4.4, don't we?

@derrabus derrabus modified the milestones: 5.3, 4.4 Jul 28, 2021
@carsonbot carsonbot changed the title Fixed decode exception when sendgrid response is 202 [Mailer] Fixed decode exception when sendgrid response is 202 Jul 28, 2021
@Nyholm
Copy link
Member
Nyholm commented Jul 29, 2021

Thank you @rubanooo for fixing this.

Could you target branch 4.4 instead?

Im happy with the changes.

@fabpot fabpot changed the base branch from 5.3 to 4.4 July 29, 2021 06:26
@fabpot fabpot force-pushed the bugfix/sendgrid-decode-exception branch from 1788fb8 to 9c6d31a Compare July 29, 2021 06:26
@fabpot
Copy link
Member
fabpot commented Jul 29, 2021

I'm going to switch this PR to 4.4 while merging.

@fabpot
Copy link
Member
fabpot commented Jul 29, 2021

Thank you @rubanooo.

@fabpot fabpot merged commit 4a28597 into symfony:4.4 Jul 29, 2021
This was referenced Jul 29, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Awaiting requested review from Nyholm

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@lyrixx lyrixx Awaiting requested review from lyrixx

@wouterj wouterj Awaiting requested review from wouterj

@xabbuh xabbuh Awaiting requested review from xabbuh

@yceruto yceruto Awaiting requested review from yceruto

Assignees
No one assigned
Labels
Bug Mailer Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@rubanooo @carsonbot @derrabus @Nyholm @fabpot
0