Fixes missing translations for Dutch (nl) #42189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
reviewed
Jul 19, 2021
src/Symfony/Component/Validator/Resources/translations/validators.nl.xlf
Outdated
Show resolved
Hide resolved
|
I see wrong ids in translations. Please check by original translation https://github.com/symfony/symfony/blob/5.4/src/Symfony/Component/Validator/Resources/translations/validators.en.xlf |
|
@StaffNowa I've checked the changes of PR #41872 and the translation ids seem correct for Dutch already |
wouterj
approved these changes
Jul 20, 2021
|
Thank you @rvanlaak. |
8000
fabpot
added a commit
that referenced
this pull request
Aug 6, 2021
…via status script (rvanlaak) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- Report mismatches between trans-unit id and source text via status script | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no<!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | related to #42197 and #42189 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> As can be seen in #42197 there are several translation mismatches between trans-unit id and source. The `translation-status.php` script helps with checking translation statusses. This PR improves that script by matching the trans-unit id and source with the base translation,  The script shows the related mismatch translation ids in `-v` verbose mode:  And now also allows to solely show incomplete locales via the `--incomplete` script argument. Commits ------- 2982eec Report mismatches between trans-unit id and source text via status script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes missing translations for Dutch (nl)
Related to #38710
The Fabbot check is a false-positive