[Security] Fix persistent remember me being only usable once #42162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate of #41897, right? |
|
Oh yes, absolutely.. Except that perhaps the other PR did not highlight the level of urgency and bugginess :) I'm happy to have this one closed, but I'd really hope this can be merged soon as it renders the remember-me feature practically unusable for us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite the head-scratching debugging session to find this one 😄
It appears the new persistent remember me was broken in this way from the very first iteration https://github.com/symfony/symfony/blame/a942b5f6849810d45aab163c40381a16d5e8dbd9~1/src/Symfony/Component/Security/Http/RememberMe/PersistentRememberMeHandler.php#L77-L80
Essentially what happens is the first time (on login) you get a cookie with a hashed token, which is also stored in token provider. Then when session drops off, the handler recreates a new cookie but with the new un-hashed token. However the new hashed token is persisted, so when the session drops off again your cookie cannot be verified anymore, and you get logged out.
The fix is simply to correctly create new cookies with the hashed token.
Please be aware that if trying to repro this, due to line 91 clearing the session cookie isn't enough, you need to also wait a minute to really trigger a new token to be created.