8000 [PhpUnitBridge] Fix composer resolution on Windows by Rainrider · Pull Request #42131 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[PhpUnitBridge] Fix composer resolution on Windows #42131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2021
Merged

[PhpUnitBridge] Fix composer resolution on Windows #42131

merged 1 commit into from
Jul 15, 2021

Conversation

Rainrider
Copy link
Contributor
@Rainrider Rainrider commented Jul 15, 2021 •
edited
Loading
Q A
Branch? 4.4 and next
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #42129
License MIT

This prepends the php executable to the resolved composer path even when COMPOSER_BINARY is set on Windows. Please see #42129 for description.

@carsonbot
8000 Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@Rainrider
Copy link
Contributor Author

The fabbot.io failure was not resolved in #41780, please tell me if I should do it here.

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Jul 15, 2021
@nicolas-grekas nicolas-grekas changed the base branch from 5.4 to 4.4 July 15, 2021 14:30
@Rainrider @nicolas-grekas
Fix composer resolution on windows
746f83a 
Prepend the php executable to the resolved composer path
when `COMPOSER_BINARY` is set.
@nicolas-grekas
Copy link
Member

Thank you @Rainrider.

@nicolas-grekas nicolas-grekas merged commit 6b2b7b9 838F into symfony:4.4 Jul 15, 2021
@Rainrider Rainrider deleted the fix/phpunit-bridge-composer-resolution branch July 15, 2021 14:44
This was referenced Jul 26, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug PhpUnitBridge Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

[PhpUnitBridge] Broken COMPOSER_BINARY on Windows
3 participants
@Rainrider @carsonbot @nicolas-grekas
0