[Form] Added right HTML types to Datetime/Date/Time types if single_text is true #4204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabpot anything else to do there? |
|
adding some unit tests? |
|
fair point :) |
|
@fabpot ok, so I had to fix some other tests but there is a weird dependency between the tests in TwigBridge, and the Form component. I fixed the test suite's setup in the TwigBridge, and fixed some failing tests. |
fabpot
added a commit
that referenced
this pull request
May 14, 2012
Commits ------- ceb5ce6 [Form] fixed tests a1e3a59 [TwigBridge] Switched to composer df36afb [Form] Added tests 6d5ad3b [Form] Added right HTML types to Datetime/Date/Time types if single_text is true Discussion ---------- [Form] Added right HTML types to Datetime/Date/Time types if single_text is true When you set the `widget` option to `single_text`, you get a HTML input tag which is fine, but you the type is `text`, and it's wrong. You don't have any other way to get the right `type` as this attribute is defined to the FormView instance itself (see FileType for instance). This PR adds right HTML types like the FileType does. Cheers, William --------------------------------------------------------------------------- by willdurand at 2012-05-09T16:04:16Z @fabpot anything else to do there? --------------------------------------------------------------------------- by fabpot at 2012-05-11T16:28:43Z adding some unit tests? --------------------------------------------------------------------------- by willdurand at 2012-05-11T16:35:40Z fair point :) --------------------------------------------------------------------------- by travisbot at 2012-05-12T16:34:43Z This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1314731) (merged 2631c8b7 into cb905c5). --------------------------------------------------------------------------- by travisbot at 2012-05-12T17:14:12Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1314902) (merged ceb5ce6 into e193452). --------------------------------------------------------------------------- by willdurand at 2012-05-12T17:16:17Z @fabpot ok, so I had to fix some other tests but there is a weird dependency between the tests in TwigBridge, and the Form component. I fixed the test suite's setup in the TwigBridge, and fixed some failing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you set the
widgetoption tosingle_text, you get a HTML input tag which is fine, but you the type istext, and it's wrong. You don't have any other way to get the righttypeas this attribute is defined to the FormView instance itself (see FileType for instance).This PR adds right HTML types like the FileType does.
Cheers,
William