10000 [Cache] Remove MemcachedTrait by derrabus · Pull Request #42014 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Cache] Remove MemcachedTrait #42014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

derrabus
Copy link
Member
@derrabus derrabus commented Jul 7, 2021
Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

This trait is not used anywhere. It had been removed once, with #31760. But it resurfaced, presumably because of a bad merge. It is flagged as @internal, so I think we can safely delete it.

Signed-off-by: Alexander M. Turek <me@derrabus.de>
@derrabus
Copy link
Member Author
derrabus commented Jul 7, 2021

I did some more research: The commit that reintroduced that file was ca8944b shortly before the 5.1.6 release.

@derrabus derrabus requested a review from nicolas-grekas July 7, 2021 10:41
@nicolas-grekas
Copy link
Member

Good catch, thanks @derrabus.

@nicolas-grekas nicolas-grekas merged commit 33c661f into symfony:5.2 Jul 7, 2021
@derrabus derrabus deleted the remove/memcached-trait branch July 7, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0