8000 Fix: Mailjet bridge tests by OskarStark · Pull Request #41985 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fix: Mailjet bridge tests #41985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Fix: Mailjet bridge tests #41985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Symfony/Component/Notifier/Bridge/Mailjet/Tests/MailjetTransportFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ public function supportsProvider(): iterable
yield [false, 'somethingElse://Mailjet:authtoken@default'];
}

public function missingRequiredOptionProvider(): iterable
public function incompleteDsnProvider(): iterable
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

password is no option, its part of user:pass of the scheme

{
yield 'missing option: from' => ['mailjet://authtoken@default'];
yield 'missing from' => ['mailjet://authtoken@default', 'Invalid "mailjet://authtoken@default" notifier DSN: Password is not set.'];
}

public function unsupportedSchemeProvider(): iterable
Expand Down
4 changes: 2 additions & 2 deletions src/Symfony/Component/Notifier/Bridge/Mailjet/Tests/MailjetTransportTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@ final class MailjetTransportTest extends TransportTestCase
/**
* @return MailjetTransport
*/
public function createTransport(?HttpClientInterface $client = null): TransportInterface
public function createTransport(HttpClientInterface $client = null): TransportInterface
{
return (new MailjetTransport('authtoken', 'Mailjet', $client ?? $this->createMock(HttpClientInterface::class)))->setHost('host.test');
}

public function toStringProvider(): iterable
{
yield ['mailjet://Mailjet:authtoken@host.test', $this->createTransport()];
yield ['mailjet://Mailjet@host.test', $this->creat A654 eTransport()];
}

public function supportedMessagesProvider(): iterable
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Notifier/Bridge/Mailjet/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"require": {
"php": ">=7.2.5",
"symfony/http-client": "^4.3|^5.0",
"symfony/notifier": "^5.3"
"symfony/notifier": "^5.3.4"
},
"autoload": {
"psr-4": { "Symfony\\Component\\Notifier\\Bridge\\Mailjet\\": "" },
Expand Down
0