8000 [FrameworkBundle][Notifier] Fix Telnyx service registration (fixes build) by wouterj · Pull Request #41868 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
8000

[FrameworkBundle][Notifier] Fix Telnyx service registration (fixes build) #41868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2021
Merged

[FrameworkBundle][Notifier] Fix Telnyx service registration (fixes build) #41868

merged 1 commit into from
Jun 27, 2021

Conversation

wouterj
Copy link
Member
@wouterj wouterj commented Jun 26, 2021
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

This was missed in #41172 and caused the build to fail in 5.4 and 6.0

@wouterj
Copy link
Member Author
wouterj commented Jun 26, 2021

I believe the current failure is caused by the Telnyx subsplit not being configured yet.

StaffNowa
StaffNowa approved these changes Jun 26, 2021
View reviewed changes
Copy link
Contributor
@StaffNowa StaffNowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing :) You are right :)

@carsonbot carsonbot changed the title [FrameworkBundle] Fix Telnyx service registration (fixes build) [FrameworkBundle][Notifier] Fix Telnyx service registration (fixes build) Jun 27, 2021
@fabpot
Copy link
Member
fabpot commented Jun 27, 2021

Thank you @wouterj.

@fabpot fabpot merged commit 2cc6956 into symfony:5.4 Jun 27, 2021
@wouterj wouterj deleted the fix-build branch June 27, 2021 11:26
@vuphuong87 vuphuong87 mentioned this pull request Jun 27, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@StaffNowa StaffNowa StaffNowa approved these changes

Assignees
No one assigned
Labels
Bug FrameworkBundle Notifier Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wouterj @fabpot @StaffNowa @carsonbot
0