[VarDumper] Fix tests for PHP 8.1 #41701
Conversation
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Part of #41552 |
| License | MIT |
| Doc PR | N/A |
9f41eb0 to
5db7f8b
Compare
src/Symfony/Component/VarDumper/Tests/Caster/ReflectionCasterTest.php
Outdated
Show resolved
Hide resolved
|
Can you explain why the dumper behaves differently on PHP 8.1? |
|
@derrabus looks like the behavior of |
|
@derrabus also, some other functions seem to have changed their behaviour. For example, when |
5db7f8b to
44efb72
Compare
I'd like to clarify first, if that change was intentional: https://bugs.php.net/bug.php?id=81147 |
|
The other changes look reasonable to me. |
|
Okay, that was fast and we've got the answer we were looking for.
Can you have a look at the Travis failure? It looks related. |
|
Thank you so much for your investigation, super good to know! I'll definitely take a look at Travis tomorrow to finish this PR. 👍 |
44efb72 to
9c00d21
Compare
9c00d21 to
f2b0822
Compare
|
@derrabus done 👌 This failing build for 7.4 seems unrelated to this PR. I'm not sure I understand the difference between "Tests / Integration (x.x)" and Travis CI tests ? |
|
Thank you @alexandre-daubois. |