8000 [2.2] [output-stream] Refactor StreamingResponse implementation to use an OutputStream by igorw · Pull Request #4146 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[2.2] [output-stream] Refactor StreamingResponse implementation to use an OutputStream #4146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

[2.2] [output-stream] Refactor StreamingResponse implementation to use an OutputStream #4146

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a2f32a9
[output-stream] Refactor StreamingResponse implementation to use an O…
igorw Jan 15, 2012
7c44cba
Merge remote-tracking branch 'upstream/master' into output-stream
igorw Jul 11, 2012
56a9192
[output-stream] Cosmetic tweak
igorw Jul 11, 2012
cc8fca3
[output-stream] Close OutputStream after serving master request
igorw Jul 11, 2012
27e8732
[output-stream] Expose the stream resource of StreamOutputStream
igorw Jul 11, 2012
8c6fcec
[output-stream] Do not close stream for twig subrequests
igorw Jul 13, 2012
6e8cbe6
Merge branch 'master' into output-stream
igorw Oct 13, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[output-stream] Cosmetic tweak
  • Loading branch information
@igorw
igorw committed Jul 11, 2012
commit 56a9192d005954fb1754976d4abafe15867d1aef
1 change: 1 addition & 0 deletions src/Symfony/Component/HttpFoundation/OutputStream/StreamOutputStream.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ public function close()
static public function create($filename)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be public static

{
$stream = fopen($filename, 'w');

return new static($stream);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing empty line

}
}
0