[WDT] added documentation link #4140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe the documentation server should redirect to the right version according to |
|
That would be best yes. |
|
FYI, I've added some more constants about the Symfony version: 48099a8 (modeled after PHP constants) |
|
I've just updated the website to accept any
|
| $this->data = array( | ||
| 'token' => $response->headers->get('X-Debug-Token'), | ||
| 'symfony_version' => Kernel::VERSION, | ||
| 'symfony_doc' => "http://symfony.com/doc/$branch/index.html", |
There was a problem hiding this comment.
You can now simplify this with just sprintf('http://symfony.com/doc/$branch/index.html', Kernel::VERSION)
There was a problem hiding this comment.
Or even better, just remove the symfony_doc data as we already have the version in symfony_version and move the URL directly into the template.
|
👍 for updating the website. But I think you missed to return 404 for a non-existent main doc page. |
|
I've fixed the doc index for non-existing versions. Can you squash your commits before I merge? Thanks. |
the doc server redirects to the correct branch according to the symfony version
|
done |
fabpot
added a commit
that referenced
this pull request
May 11, 2012
Commits ------- 709be4b [WDT] added documentation link Discussion ---------- [WDT] added documentation link This adds a documentation link in the WDT for the appropriate branch according to the current symfony version. @weaverryan there is no documentation branch yet for the currently created 2.1 branch. Also it might be a nice feature to redirect the dev branch to master automatically on the website. I.e. `http://symfony.com/doc/2.1/index.html` -> `http://symfony.com/doc/master/index.html` @fabpot It might be a good idea to introduce a `Kernel::BRANCH` constant. So there would be no need to extract the branch from the symfony version in `ConfigDataCollector`. And bumping new versions/branches would be in one place. --------------------------------------------------------------------------- by vicb at 2012-04-27T14:17:07Z Maybe the documentation server should redirect to the right version according to `Kernel::VERSION` (i.e. using rewritting) ? --------------------------------------------------------------------------- by Tobion at 2012-04-27T14:31:49Z That would be best yes. --------------------------------------------------------------------------- by fabpot at 2012-05-10T06:03:45Z FYI, I've added some more constants about the Symfony version: 48099a8 (modeled after PHP constants) --------------------------------------------------------------------------- by fabpot at 2012-05-10T07:08:57Z I've just updated the website to accept any `HttpKernel::VERSION` string. Some redirection examples: * 2.0.12 -> current * 2.0 -> current * 2.0.12-DEV -> current * 2.1 -> master * 2.1.0-DEV -> master --------------------------------------------------------------------------- by Tobion at 2012-05-10T12:49:16Z :thumbsup: for updating the website. But I think you missed to return 404 for a non-existent main doc page. http://symfony.com/doc/2.4/book/controller.html -> 404 as expected http://symfony.com/doc/2.4/index.html -> does not return 404 (and all links there are dead) --------------------------------------------------------------------------- by travisbot at 2012-05-10T15:12:07Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1296057) (merged 04adf361 into a01dec0). --------------------------------------------------------------------------- by fabpot at 2012-05-10T17:21:06Z I've fixed the doc index for non-existing versions. Can you squash your commits before I merge? Thanks. --------------------------------------------------------------------------- by Tobion at 2012-05-10T22:49:18Z done --------------------------------------------------------------------------- by travisbot at 2012-05-10T22:52:13Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1300414) (merged 709be4b into fae4523).
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
Commits ------- 709be4b [WDT] added documentation link Discussion ---------- [WDT] added documentation link This adds a documentation link in the WDT for the appropriate branch according to the current symfony version. @weaverryan there is no documentation branch yet for the currently created 2.1 branch. Also it might be a nice feature to redirect the dev branch to master automatically on the website. I.e. `http://symfony.com/doc/2.1/index.html` -> `http://symfony.com/doc/master/index.html` @fabpot It might be a good idea to introduce a `Kernel::BRANCH` constant. So there would be no need to extract the branch from the symfony version in `ConfigDataCollector`. And bumping new versions/branches would be in one place. --------------------------------------------------------------------------- by vicb at 2012-04-27T14:17:07Z Maybe the documentation server should redirect to the right version according to `Kernel::VERSION` (i.e. using rewritting) ? --------------------------------------------------------------------------- by Tobion at 2012-04-27T14:31:49Z That would be best yes. --------------------------------------------------------------------------- by fabpot at 2012-05-10T06:03:45Z FYI, I've added some more constants about the Symfony version: 48099a8 (modeled after PHP constants) --------------------------------------------------------------------------- by fabpot at 2012-05-10T07:08:57Z I've just updated the website to accept any `HttpKernel::VERSION` string. Some redirection examples: * 2.0.12 -> current * 2.0 -> current * 2.0.12-DEV -> current * 2.1 -> master * 2.1.0-DEV -> master --------------------------------------------------------------------------- by Tobion at 2012-05-10T12:49:16Z :thumbsup: for updating the website. But I think you missed to return 404 for a non-existent main doc page. http://symfony.com/doc/2.4/book/controller.html -> 404 as expected http://symfony.com/doc/2.4/index.html -> does not return 404 (and all links there are dead) --------------------------------------------------------------------------- by travisbot at 2012-05-10T15:12:07Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1296057) (merged 04adf361 into a01dec0). --------------------------------------------------------------------------- by fabpot at 2012-05-10T17:21:06Z I've fixed the doc index for non-existing versions. Can you squash your commits before I merge? Thanks. --------------------------------------------------------------------------- by Tobion at 2012-05-10T22:49:18Z done --------------------------------------------------------------------------- by travisbot at 2012-05-10T22:52:13Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1300414) (merged 709be4b into fae4523).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a documentation link in the WDT for the appropriate branch according to the current symfony version.
@weaverryan there is no documentation branch yet for the currently created 2.1 branch.
Also it might be a nice feature to redirect the dev branch to master automatically on the website. I.e.
http://symfony.com/doc/2.1/index.html->http://symfony.com/doc/master/index.html@fabpot It might be a good idea to introduce a
Kernel::BRANCHconstant. So there would be no need to extract the branch from the symfony version inConfigDataCollector. And bumping new versions/branches would be in one place.