[Form] fix support for years outside of the 32b range on x86 arch #41394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
b0588de to
ac4f715
Compare
nicolas-grekas
commented
May 24, 2021
| @@ -118,7 +118,7 @@ public function testConsumeRememberMeCookieExpired() | |||
| $this->tokenProvider->expects($this->any()) | |||
| ->method('loadTokenBySeries') | |||
| ->with('series1') | |||
| ->willReturn(new PersistentToken(InMemoryUser::class, 'wouter', 'series1', 'tokenvalue', new \DateTime('-'.(31536000 - 1).' years'))); | |||
| ->willReturn(new PersistentToken(InMemoryUser::class, 'wouter', 'series1', 'tokenvalue', new \DateTime('-'.(31536000 - 1).' months'))); | |||
There was a problem hiding this comment.
/cc @wouterj WDYT?
There was a problem hiding this comment.
To me, seems like we can even make this '-'.(31536000 + 1).' seconds'?
stof
reviewed
May 24, 2021
|
|
||
| throw new MethodArgumentValueNotImplementedException(__METHOD__, 'timestamp', $timestamp, $message); | ||
| } | ||
|
|
||
| if (\is_string($timestamp) && $dt = \DateTime::createFromFormat('U', $timestamp)) { |
There was a problem hiding this comment.
This should also be applied to the polyfills repo, right ?
There was a problem hiding this comment.
yep, see symfony/polyfill#357
stof
approved these changes
May 24, 2021
This was referenced May 31, 2021
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.