[Routing] Fix the matching process #4139
Conversation
|
Your using the wrong slash ( |
|
@Tobion fixed, thanks. |
|
@vicb Does your fix also take into account: Thanks |
|
@dlsniper in your example the separator for the |
|
@vicb yes, that's what I mean. Currently I have something like your example but I want to have the Thanks. P.S. when will this be merged? |
|
@dlsniper this PR only fixes the choice of a separator, the matching process is left unchanged, i.e. the behavior will be the same when a variable in the last position is optional and followed by a separator. Closing to submit against the master branch. |
Commits ------- a196ca0 [Routing] Compiler: remove lazy quantifiers with no effect 8232aa1 [Routing] Compiler: fix in the computing of the segment separators Discussion ---------- [Routing] Fix the matching process This PR is based on the PR #3678, #4139. [](http://travis-ci.org/vicb/symfony) **The spec** A pattern is composed of both text and variable segments: `/{variable}-test/{other_variable}`. A variable segment will match anything until a separator is encountered. The separator is the character following the variable segment when available or preceding the variable otherwise (i.e. at the end of the pattern). That is: * the separator is `-` for the `variable`, * the separator is `/` for the `other_variable`. *Note: This default matching behavior can be overridden if a requirement is specified for a variable)* **Fixes** * The current behavior is to consider booth the preceding and following characters as separators (considering availability), * The "preceding" separator of the first variable is always set to `/` whatever the preceding character is (due to `$pos = 0` for the first iteration). **Todo** Update the doc once this is merged
This PR is based on the PR #3678.
The spec
A pattern is composed of both text and variable segments:
/{variable}-test/{other_variable}.A variable segment will match anything until a separator is encountered. The separator is the character following the variable segment when available or preceding the variable otherwise (i.e. at the end of the pattern).
That is:
-for thevariable,/for theother_variable.Note: This default matching behavior can be overridden if a requirement is specified for a variable)
Fixes
/whatever the preceding character is (due to$pos = 0for the first iteration).Todo
Update the doc once this is merged