-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
{{ message }}
[Ldap] Removed deprecated code #41363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you have a look at the Psalm error? |
derrabus
reviewed
May 21, 2021
Contributor
Author
I will revert the deletion of the methods. Probably it's better to delete it if somebody starts to clean up the |
malteschlueter
commented
May 21, 2021
|
|
||
| $user = $passport->getUser(); | ||
| if (!$user instanceof PasswordAuthenticatedUserInterface) { | ||
| trigger_deprecation('symfony/ldap', '5.3', 'Not implementing the "%s" interface in class "%s" while using password-based authenticators is deprecated.', PasswordAuthenticatedUserInterface::class, get_debug_type($user)); |
Contributor
Author
There was a problem hiding this comment.
Should this now also a exception?
Member
There was a problem hiding this comment.
IMHO it does not need to, we can just remove the deprecation here.
Reason for this notice to be here is that in order to remove getPassword() from the generic UserInterface, we needed to trigger deprecation notices from as much places as possible to make sure developers get it. Here we don't use anything from PasswordAuthenticatedUserInterface so nothing to do.
Member
I think, deleting |
Member
|
Please rebase, I've merged my two PRs up. |
derrabus
approved these changes
May 21, 2021
chalasr
approved these changes
May 21, 2021
Member
|
Thanks for all the PRs! I'm not sure if you were planning to, but I would propose to leave the security packages (other than this one) as-is for now. There is quite some deprecated code, as well as undeprecated but redundant code if we remove deprecation features. So we probably have to remove them per feature instead of per package. Let's make a plan when 5.3 is stable :) |
Member
|
Thank you @malteschlueter. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This remove deprecated code from Ldap.
Do I have to update the upgrade log for the two method deletions or is it unnecessary because it's mentioned in the security?