[Form] Replace broken ServerParams mock#41238
Merged
nicolas-grekas merged 1 commit intosymfony:4.4from May 16, 2021
Merged
Conversation
Member
|
Thank you @derrabus. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractRequestHandlerTestcreates a mocked version of theServerParamsclass. SincegetNormalizedIniPostMaxSize()does not have a return type declaration, PHPUnit will by default create an implementation that always returnsnull. However, the real implementation of that method guarantees to always return a string.This becomes problematic in PHP 8.1 because the return value is sometimes passed as-is into functions like
strtolower()which trigger a deprecation warning onnullnow.This PR proposes to replace the mock with a dummy implementation that returns an empty string by default.