10000 [Security] Add missing Spanish translations by makraz · Pull Request #41100 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Security] Add missing Spanish translations #41100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2021
Merged

[Security] Add missing Spanish translations #41100

merged 1 commit into from
May 4, 2021

Conversation

makraz
Copy link
Contributor
@makraz makraz commented May 4, 2021
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #41083
License MIT
Doc PR N/A

@makraz makraz requested review from chalasr and wouterj as code owners May 4, 2021 05:40
@carsonbot carsonbot added this to the 4.4 milestone May 4, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@makraz makraz mentioned this pull request May 4, 2021
Closed
javiereguiluz
javiereguiluz approved these changes May 4, 2021
View reviewed changes
Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a minor uppercase/lowercase issue to fix, but everything else is great. Thanks @makraz.

@makraz
Copy link
Contributor Author
makraz commented May 4, 2021

There's a minor uppercase/lowercase issue to fix, but everything else is great. Thanks @makraz.

I fixed the typo
thank you @javiereguiluz

@derrabus
Copy link
Member
derrabus commented May 4, 2021

Thank you @makraz.

@derrabus derrabus merged commit 4d3768f into symfony:4.4 May 4, 2021
@makraz makraz deleted the bugfix/spanish-translations branch May 4, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@makraz @carsonbot @derrabus @javiereguiluz
0