8000 [Security] Update Czech translations by mhujer · Pull Request #41093 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Security] Update Czech translations #41093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2021

Conversation

mhujer
Copy link
Contributor
@mhujer mhujer commented May 3, 2021
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #41040
License MIT

Closes #41040

The translations are not perfect for some %minutes% values as the pluralization is more complicated in Czech than in English. (See: #40863 (comment))

@lku
Copy link
lku commented May 3, 2021

Another Czech native here, I can confirm this change is OK from the language perspective 🙂

But I think the target branch should be 4.4

@chalasr chalasr added this to the 4.4 milestone May 3, 2021
- closes symfony#41040
- The translations are not perfect for some %minutes% values
   as the pluralization is more complicated in Czech than in English.
- See: symfony#40863 (comment)
@chalasr chalasr changed the base branch from 5.x to 4.4 May 4, 2021 15:37
@chalasr chalasr force-pushed the mh-security-czech-translations branch from 40a711d to 076310c Compare May 4, 2021 15:37
@chalasr
Copy link
Member
chalasr commented May 4, 2021

Thank you @mhujer.

@chalasr chalasr merged commit 98d3201 into symfony:4.4 May 4, 2021
@mhujer mhujer deleted the mh-security-czech-translations branch May 4, 2021 15:55
@mhujer
Copy link
Contributor Author
mhujer commented May 4, 2021

@chalasr thanks! And sorry about the incorrect branch, I thought that Rate Limiter was added only in 5.x

@derrabus
Copy link
Member
derrabus commented May 4, 2021

And sorry about the incorrect branch, I thought that Rate Limiter was added only in 5.x

We merge all translations to 4.4. Nobody wants to resolve merge conflicts on translation files. 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing translations for Czech (cs)
6 participants
0