8000 [CI] Make sure to restore default locale by Nyholm · Pull Request #40932 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[CI] Make sure to restore default locale #40932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2021
Merged

[CI] Make sure to restore default locale #40932

merged 1 commit into from
Apr 23, 2021

Conversation

Nyholm
Copy link
Member
@Nyholm Nyholm commented Apr 23, 2021
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets F
License MIT
Doc PR

Whenever we have a test that do \Locale::setDefault() we must make sure to restore it to the original value.

@carsonbot carsonbot added this to the 4.4 milestone Apr 23, 2021
@derrabus
Copy link
Member

Thank you Tobias.

@derrabus derrabus force-pushed the default-locale-restore branch from afa4a14 to a5afe47 Compare April 23, 2021 21:06
@derrabus derrabus m 7CE5 erged commit 84b03c1 into symfony:4.4 Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

@xabbuh xabbuh xabbuh approved these changes

@yceruto yceruto yceruto approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@Nyholm @derrabus @xabbuh @yceruto @carsonbot
0