10000 [PropertyInfo] fix attribute namespace with recursive traits by soullivaneuh · Pull Request #40874 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[PropertyInfo] fix attribute namespace with recursive traits #40874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2021
Merged

[PropertyInfo] fix attribute namespace with recursive traits #40874

merged 1 commit into from
May 7, 2021

Conversation

soullivaneuh
Copy link
Contributor
@soullivaneuh soullivaneuh commented Apr 19, 2021 •
edited
Loading
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #36997
License MIT
Doc PR symfony/symfony-docs#...

The targeted issue is closed because considered as solved by #40175.

However, the fix is not enough and is not working with recursive trait inclusion. (see #36997 (comment)).

This pull request is completing the first fix of @xabbuh, trying to follow the same coding style. 😉

@soullivaneuh soullivaneuh requested a review from dunglas as a code owner April 19, 2021 16:26
@carsonbot carsonbot added this to the 4.4 milestone Apr 19, 2021
soullivaneuh
soullivaneuh commented Apr 19, 2021
View reviewed changes
src/Symfony/Component/PropertyInfo/Extractor/PhpDocExtractor.php

try {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I moved the login out the try/catch block because as far as I know, this statement is for the $this->docBlockFactory->create line below, not for the recursive resolution.

Please tell me if I'm wrong. 👍

@soullivaneuh soullivaneuh mentioned this pull request Apr 19, 2021
Closed
@nicolas-grekas nicolas-grekas changed the title fix(property-info): wrong attribute namespace with recursive traits [PropertyInfo] fix attribute namespace with recursive traits Apr 20, 2021
@carsonbot carsonbot changed the title [PropertyInfo] fix attribute namespace with recursive traits fix attribute namespace with recursive traits Apr 20, 2021
@carsonbot carsonbot changed the title fix attribute namespace with recursive traits [PropertyInfo] fix attribute namespace with recursive traits Apr 21, 2021
@nicolas-grekas nicolas-grekas force-pushed the property-info/recursive-traits-fix branch from 1be04b8 to bbadfb3 Compare May 7, 2021 13:17
@nicolas-grekas
Copy link
Member

Thank you @soullivaneuh.

@nicolas-grekas nicolas-grekas merged commit ba38346 into symfony:4.4 May 7, 2021
@fabpot fabpot mentioned this pull request May 9, 2021
Merged
@soullivaneuh soullivaneuh deleted the property-info/recursive-traits-fix branch May 12, 2021 10:53
This was referenced May 12, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug PropertyInfo Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@soullivaneuh @nicolas-grekas @fabpot @carsonbot
0