-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[PropertyInfo] fix attribute namespace with recursive traits #40874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PropertyInfo] fix attribute namespace with recursive traits #40874
Conversation
|
||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I moved the login out the try/catch
block because as far as I know, this statement is for the $this->docBlockFactory->create
line below, not for the recursive resolution.
Please tell me if I'm wrong. 👍
Sorry, something went wrong.
All reactions
-
👍 1 reaction
src/Symfony/Component/PropertyInfo/Tests/Fixtures/TraitUsage/DummyTrait.php
Show resolved
Hide resolved
1be04b8
to
bbadfb3
Compare
Thank you @soullivaneuh. |
All reactions
-
👍 1 reaction
Sorry, something went wrong.
fabpot
nicolas-grekas
dunglas
Successfully merging this pull request may close these issues.
The targeted issue is closed because considered as solved by #40175.
However, the fix is not enough and is not working with recursive trait inclusion. (see #36997 (comment)).
This pull request is completing the first fix of @xabbuh, trying to follow the same coding style. 😉