8000 [WebProfilerBundle] Use ControllerReference instead of URL in twig render() by Foxprodev · Pull Request #40791 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[WebProfilerBundle] Use ControllerReference instead of URL in twig render() #40791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2021
Merged

[WebProfilerBundle] Use ControllerReference instead of URL in twig render() #40791

merged 1 commit into from
Apr 13, 2021

Conversation

Foxprodev
Copy link
Contributor
Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #40709
License MIT
Doc PR

Use ControllerReference instead of UrlGenerator's URL. Helps to deal with different baseUrl

Feel free to help me with some advice. Thank you in advance

@Foxprodev Foxprodev changed the base branch from 5.x to 5.2 April 13, 2021 07:37
@nicolas-grekas nicolas-grekas added this to the 5.2 milestone Apr 13, 2021
@carsonbot carsonbot changed the title [WebProfiler] Use ControllerReference instead of URL in twig render() [WebProfilerBundle] [WebProfiler] Use ControllerReference instead of URL in twig render() Apr 13, 2021
@derrabus derrabus changed the title [WebProfilerBundle] [WebProfiler] Use ControllerReference instead of URL in twig render() [WebProfilerBundle] Use ControllerReference instead of URL in twig render() Apr 13, 2021
stof
stof approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member
@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, this was done this way because the inline strategy was not supporting controller references without the special /_fragment URL in the past (which is used to support them for ESI/SSI strategies).
As this limitation has been removed since a long time, I'm OK with the change

@derrabus
Copy link
Member

Thank you @Foxprodev.

@derrabus derrabus merged commit ade71f0 into symfony:5.2 Apr 13, 2021
@fabpot fabpot mentioned this pull request May 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed WebProfilerBundle
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

Symfony profiler does not work with x-forwarded-prefix header
5 participants
@Foxprodev @derrabus @stof @nicolas-grekas @carsonbot
0