8000 [HttpKernel] Minor fixes and tweaks in the Symfony Welcome Page by javiereguiluz · Pull Request #40777 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[HttpKernel] Minor fixes and tweaks in the Symfony Welcome Page #40777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

javiereguiluz
Copy link
Member
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR (not needed)

The current "Welcome Page" has a minor issue related to CSS flexbox. See how the "debug mode" text looks in smaller screens:

before

The solution is to wrap the contents in a HTML element such as <p>, but this PR also does some other minor tweaks. This is how it'd look now:

after

@javiereguiluz javiereguiluz added this to the 4.4 milestone Apr 12, 2021
@carsonbot carsonbot changed the title Minor fixes and tweaks in the Symfony Welcome Page [HttpKernel] Minor fixes and tweaks in the Symfony Welcome Page Apr 12, 2021
@nicolas-grekas
Copy link
Member

Thank you @javiereguiluz.

< 8F7D div class="pr-review-reactions ">

@nicolas-grekas nicolas-grekas merged commit e05b4ef into symfony:4.4 Apr 12, 2021
@javiereguiluz javiereguiluz deleted the tweak_welcome_page branch April 12, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0