8000 Fix 'Cannot access parent:: when current class scope has no parent' error by Androbin · Pull Request #40774 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fix 'Cannot access parent:: when current class scope has no parent' error#40774

Closed
Androbin wants to merge 1 commit intosymfony:4.4from
Androbin:parent
Closed

Fix 'Cannot access parent:: when current class scope has no parent' error#40774
Androbin wants to merge 1 commit intosymfony:4.4from
Androbin:parent

Conversation

@Androbin
Copy link
Copy Markdown
@Androbin Androbin commented Apr 12, 2021 •
edited
Loading
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR 
Script Sensio\Bundle\DistributionBundle\Composer\ScriptHandler::clearCache handling the symfony-scripts event terminated with an exception

  [RuntimeException]
  An error occurred when executing the "'cache:clear --no-warmup'" command:

  PHP Fatal error: Uncaught Symfony\Component\Debug\Exception\FatalThrowableError: Cannot access parent:: when current class scope has no parent in ./vendor/symfony/symfony/src/Symfony/Component/Config/Resource/ReflectionClassResource.php:167
  Stack trace:
  #0 ./vendor/symfony/symfony/src/Symfony/Component/Config/Resource/ReflectionClassResource.php(167): defined()
  #1 ./vendor/symfony/symfony/src/Symfony/Component/Config/Resource/ReflectionClassResource.php(117): Symfony\Component\Config\Resource\ReflectionClassResource->generateSignature()
  #2 ./vendor/symfony/symfony/src/Symfony/Component/Config/Resource/ReflectionClassResource.php(66): Symfony\Component\Config\Resource\ReflectionClassResource->computeHash()
  #3 [internal function]: Symfony\Component\Config\Resource\ReflectionClassResource->serialize()
  #4 ./vendor/symfony/s in ./vendor/symfony/symfony/src/Symfony/Component/Config/Resource/ReflectionClassResource.php on line 167

@carsonbot
Copy link
Copy Markdown
carsonbot commented Apr 12, 2021

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot added the Bug label Apr 12, 2021
@carsonbot
Copy link
Copy Markdown
carsonbot commented Apr 12, 2021

Hey!

But you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 4.4, 5.2.

Cheers!

Carsonbot

@Androbin Androbin changed the base branch from 3.4 to 4.4 April 12, 2021 02:28
@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Apr 12, 2021
nicolas-grekas
nicolas-grekas reviewed Apr 12, 2021
View reviewed changes
src/Symfony/Component/Config/Resource/ReflectionClassResource.php
}

if (!$p->isDefaultValueConstant() || \defined($p->getDefaultValueConstantName())) {
$defaultValueConstantName = preg_replace('/^parent::/', 'pimax\Messages\Message::', $p->getDefaultValueConstantName());
Copy link
Copy Markdown
Member
@nicolas-grekas nicolas-grekas Apr 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harcoding "pimax" in the source code of Symfony doesn't make sense.
Maybe you can provide us with a reproducer? Or better, a failing test case?

Copy link
Copy Markdown
Author
@Androbin Androbin Apr 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that the name of the type of $m?

Copy link
Copy Markdown
Member
@nicolas-grekas nicolas-grekas Apr 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry I don't understand, there is no $m on this line.

@Androbin
Copy link
Copy Markdown
Author
Androbin commented Apr 14, 2021 •
edited
Loading

@nicolas-grekas Minimal reproducing test project: test-project.zip, only need to run composer install

@Androbin Androbin mentioned this pull request May 7, 2021
Closed
@Androbin Androbin deleted the parent branch June 23, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

Assignees

No one assigned

Labels

Bug Status: Needs Review

Projec 4923 ts

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

3 participants

@Androbin @carsonbot @nicolas-grekas
0