8000 allow null for framework.translator.default_path by SimonHeimberg · Pull Request #40744 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

allow null for framework.translator.default_path #40744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2021
Merged

allow null for framework.translator.default_path #40744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
allow null for framework.translator.default_path 
Allow to configure framework.translator.default_path to null, as it was until symfony 3.4.x (fix BC compatibility).

fixes #37111
  • Loading branch information
@SimonHeimberg
SimonHeimberg committed Apr 9, 2021
commit 6fd21ce5aa8679f900e1ad059c78967cd83e79c9
4 changes: 3 additions & 1 deletion src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1213,7 +1213,9 @@ private function registerTranslatorConfiguration(array $config, ContainerBuilder
$container->getDefinition('console.command.translation_update')->replaceArgument(6, $transPaths);
}

if ($container->fileExists($defaultDir)) {
if (null === $defaultDir) {
// allow null
} elseif ($container->fileExists($defaultDir)) {
$dirs[] = $defaultDir;
} else {
$nonExistingDirs[] = $defaultDir;
Expand Down
0