[Mailer][Notifier] added missing gitattributes and gitignore #40696
Conversation
|
My bridges PR the same will have this issue |
in 4.4 there is no Mailer/Bridge/Mailjet and Notification component, so nothing in there in 5.2 it is applicable for all existing there bridges Should I create merge request for 5.2? |
Yes, please! |
|
|
I've merged some of these in 5.2. Let's wait (a day or two) until someone core team member merge 5.2 into 5.x. After that we should rebase this PR. |
✅ |
|
I merged this PR in 7121009 Thank you 👍 |
…, StaffNowa) This PR was merged into the 5.3-dev branch. Discussion ---------- [Notifier] Add LightSms notifier bridge | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | License | MIT | Doc PR | symfony/symfony-docs/pull/15178 | Recipe PR | symfony/recipes#921 LightSms notifier https://github.com/D4DLab/lightsms-notifier Commits ------- 37c665e * LightSmsTransport.php - make fabbot happy 68a12fa * fix tests f1f83b9 * LightSmsTransport.php - use query string parameters 026dcd9 * LightSmsTransport.php - isset 2a9ac2d * LightSmsTransport.php - fix 4213564 * composer.json - fix Fabien comment from another pull request #40646 21e972a * coding standard bea5256 * type cast. On success lightsms return error code like string. On error return integer. 9b2e2d0 * type cast. On success lightsms return error code like string. On error return integer. 0d7488b * type cast. On success lightsms return error code like string. On error return integer. 9a832ef * LightSmsTransport.php - via mistake removed www which return (Closing direction to the user). Removed additional isset which in reality not needed. Added new method which allow to return "unknown error" and throw exception if not successfully 178d9c2 * pull request #40696 95e82f6 Update LightSmsTransport.php a197dee * LightSmsTransport.php - better to remove if we do not have it? 83d2598 * Coding Standard patch 1ff97e4 * LightSmsTransport.php - build signature and use http_build_query, timestamp int 1c993b7 * ERROR_CODES -> int * www. - bug * isset validate ['error'] 1b59a7d * LightSmsTransport.php - string param 58ac708 * LightSmsTransport.php - return back www (without will not work). Now fail tests b9f9ff8 * LightSmsTransport.php - tests fail 265f776 * LightSmsTransport.php - issue with Symfony\Component\Notifier\Bridge\LightSms\Tests\LightSmsTransportTest 23a446a * LightSmsTransport.php - issue with Symfony\Component\Notifier\Bridge\LightSms\Tests\LightSmsTransportTest 08235e5 * LightSmsTransport.php - bug fix 80ef5ba * LightSmsTransport.php - Unable to send the SMS: Closing direction to the user 08b0729 Update LightSmsTransport.php 7180c1f Update LightSmsTransport.php f16b4d2 * phone changed to from 7f13dbf * sender changed to from e20ef1e * LightSmsTransport.php - change + to 00 b0e64b9 * LightSmsTransport.php - not ok throw exception fc13bb2 * LightSmsTransport.php - changed login for validation (the same like we have all places) 5d2e692 * LightSmsTransport.php - escape phone number 8620e82 * LightSmsTransport.php - move timestamp 66c34ba Update README.md 2e0e1d7 Update README.md 7b51e0d Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php 079406e Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php 0e41bc9 Update src/Symfony/Component/Notifier/Bridge/LightSms/Tests/LightSmsTransportFactoryTest.php 3d0d79c Update src/Symfony/Component/Notifier/Bridge/LightSms/Tests/LightSmsTransportFactoryTest.php e0a68bd Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php 1b073c2 Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php b0891be Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php 49b4780 Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php b2e4638 Update src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php c02dbbd Update src/Symfony/Component/Notifier/Bridge/LightSms/README.md 9f89014 Update src/Symfony/Component/Notifier/Bridge/LightSms/README.md 5e54dfe * LightSmsTransport.php - quick fix for private constant. 3cbbc85 * HOST split into two parts 9e1809e * small changes febff46 Update src/Symfony/Component/Notifier/Bridge/LightSms/LICENSE 4a11b94 * github account author 728a3e2 * Transport.php - missing use ce41756 * notifier_transports.php - Coding Standard d1ccd46 * Attached file changes which are required to run the lightsms notifier a0fae7d * tests 15686c0 * LightSmsTransport.php - Coding Standard 2f65b92 * LightSmsTransport.php - Coding Standard 6792535 * composer.json - requirements bug fix 167f325 * LightSmsTransport.php - logic error be8f994 * LightSmsTransport.php - return type f2ba226 * LightSmsTransport.php - bug fix b075c0e * LightSms notifier
This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [CI] Make sure packages contain all metafiles | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | This PR introduce a new CI job to just do some checks on a package. It first looks at the git diff to figure out what packages have changed. Then for each changed package it verifies: - .gitattributes exists - .gitignore exists - CHANGELOG.md exists - LICENSE exists - phpunit.xml.dist exists - README.md exists - The LICENSE file includes "Fabien Potencier", the correct year and has same content as /LICENSE If the package is new (license file changed), we also make sure that the package is present in composer.json's replace. I got this idea after seeing PRs like #40696. And we do add one or two package every month. Commits ------- 18658a2 [CI] Make sure packages contain all metafiles
just added missing .gitattributes and .gitignore to be consistent with other components